[java-shib-metadata] branch main updated: JSMD-4 - Adjust unnecessary lazy-init declarations in parsers

Scott Cantor cantor.2 at osu.edu
Wed May 24 12:19:59 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-metadata.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-metadata.git;a=commit;h=148da7ef41d5543ff2519c11a9045dce5218afbd

The following commit(s) were added to refs/heads/main by this push:
     new 148da7ef JSMD-4 - Adjust unnecessary lazy-init declarations in parsers
148da7ef is described below

commit 148da7ef41d5543ff2519c11a9045dce5218afbd
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Wed May 24 08:19:57 2023 -0400

    JSMD-4 - Adjust unnecessary lazy-init declarations in parsers
    
    https://shibboleth.atlassian.net/browse/JSMD-4
    
    Fix filter parsers.
---
 .../java/net/shibboleth/spring/metadata/filter/ByReferenceParser.java   | 2 --
 .../net/shibboleth/spring/metadata/filter/NameIDFormatFilterParser.java | 2 --
 .../net/shibboleth/spring/metadata/filter/NodeProcessingParser.java     | 2 --
 3 files changed, 6 deletions(-)

diff --git a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/ByReferenceParser.java b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/ByReferenceParser.java
index d7b799ee..b7ca69e7 100644
--- a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/ByReferenceParser.java
+++ b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/ByReferenceParser.java
@@ -55,8 +55,6 @@ public class ByReferenceParser extends AbstractMetadataFilterParser {
     @Override protected void doParse(@Nonnull final Element element, @Nonnull final ParserContext parserContext,
             @Nonnull final BeanDefinitionBuilder builder) {
         super.doParse(element, parserContext, builder);
-        
-        builder.setLazyInit(false);
 
         final List<Element> children = ElementSupport.getChildElements(element,
                 new QName(AbstractMetadataProviderParser.METADATA_NAMESPACE, "MetadataFilters"));
diff --git a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NameIDFormatFilterParser.java b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NameIDFormatFilterParser.java
index a733380b..ffc4209f 100644
--- a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NameIDFormatFilterParser.java
+++ b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NameIDFormatFilterParser.java
@@ -57,8 +57,6 @@ public class NameIDFormatFilterParser extends AbstractMetadataFilterParser {
     @Override protected void doParse(@Nonnull final Element element, @Nonnull final ParserContext parserContext,
             @Nonnull final BeanDefinitionBuilder builder) {
         super.doParse(element, parserContext, builder);
-        
-        builder.setLazyInit(true);
 
         if (element.hasAttributeNS(null, "removeExistingFormats")) {
             builder.addPropertyValue("removeExistingFormats", 
diff --git a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NodeProcessingParser.java b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NodeProcessingParser.java
index e0206a5a..289e3a44 100644
--- a/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NodeProcessingParser.java
+++ b/shib-metadata-spring/src/main/java/net/shibboleth/spring/metadata/filter/NodeProcessingParser.java
@@ -51,8 +51,6 @@ public class NodeProcessingParser extends AbstractMetadataFilterParser {
     @Override protected void doParse(@Nonnull final Element element, @Nonnull final ParserContext parserContext,
             @Nonnull final BeanDefinitionBuilder builder) {
         super.doParse(element, parserContext, builder);
-        
-        builder.setLazyInit(true);
 
         final List<Element> children =
                 ElementSupport.getChildElements(element, MetadataNamespaceHandler.METADATA_NODE_PROC_ELEMENT_NAME);

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list