[JIRA] (IDP-2115) Plugin Installer is doing logging wrongly

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMzFmMmI5ZTAwMGYwNGU2MTliMWY3ZGE2OGY0ZWUwNjgiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/IDP-2115?atlOrigin=eyJpIjoiMzFmMmI5ZTAwMGYwNGU2MTliMWY3ZGE2OGY0ZWUwNjgiLCJwIjoiaiJ9 ) IDP-2115 ( https://shibboleth.atlassian.net/browse/IDP-2115?atlOrigin=eyJpIjoiMzFmMmI5ZTAwMGYwNGU2MTliMWY3ZGE2OGY0ZWUwNjgiLCJwIjoiaiJ9 ) Plugin Installer is doing logging wrongly ( https://shibboleth.atlassian.net/browse/IDP-2115?atlOrigin=eyJpIjoiMzFmMmI5ZTAwMGYwNGU2MTliMWY3ZGE2OGY0ZWUwNjgiLCJwIjoiaiJ9 )

Issue Type: Bug Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Created: 19/May/23 8:32 AM Priority: Trivial Reporter: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 )

Its doing all the right things, not necessarily in the right order.

Specifically its is setting up the logger at class initialization, when it should be doing a delayed instantiation via the getLog() call. This means that all the logging control is for nothing

h:\Perforce\idp\bin>plugin -L --verbose
Plugin net.shibboleth.idp.plugin.rhino: version 1.0.0 available for install
Plugin net.shibboleth.idp.plugin.metadatagen: version 1.0.1 available for install
Plugin net.shibboleth.idp.plugin.nashorn: version 1.1.0 available for install

h:\Perforce\idp\bin>plugin -l --verbose
No plugins installed

vs

h:\Perforce\idp\bin>plugin -L --verbose
2023-05-19 13:31:03,452 - DEBUG [net.shibboleth.idp.installer.plugin.impl.PluginInstallerCLI:271] - Initializing Spring context with [class path resource [net/shibboleth/idp/conf/http-client.xml]]
2023-05-19 13:31:03,531 - DEBUG [net.shibboleth.shared.spring.custom.SchemaTypeAwareXMLBeanDefinitionReader:393] - Loaded 9 bean definitions from class path resource [net/shibboleth/idp/conf/http-client.xml]
20.....
h:\Perforce\idp\bin>plugin -l --verbose
2023-05-19 13:31:09,701 - DEBUG [net.shibboleth.idp.installer.plugin.impl.PluginInstallerCLI:271] - Initializing Spring context with [class path resource [net/shibboleth/idp/conf/http-client.xml]]
2023-05-19 13:31:09,798 - DEBUG [net.shibboleth.shared.spring.custom.SchemaTypeAwareXMLBeanDefinitionReader:393] - Loaded 9 bean definitions from class path resource [net/shibboleth/idp/conf/http-client.xml]
2023-05-19 13:31:09,798 - DEBUG [net.shibboleth.idp.spring.IdPProp
.....

( https://shibboleth.atlassian.net/browse/IDP-2115#add-comment?atlOrigin=eyJpIjoiMzFmMmI5ZTAwMGYwNGU2MTliMWY3ZGE2OGY0ZWUwNjgiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2115#add-comment?atlOrigin=eyJpIjoiMzFmMmI5ZTAwMGYwNGU2MTliMWY3ZGE2OGY0ZWUwNjgiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:9dd72a2 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230519/9bd8963c/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-828252ba-e955-412f-8c11-b5df8def7032
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230519/9bd8963c/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-cca5ee52-886a-4306-aee0-dfaded669f05
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230519/9bd8963c/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6b2d7d5b-14af-42da-a1bb-07119a26009d
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230519/9bd8963c/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-12813b0c-b753-44da-9c86-607ed5323475
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230519/9bd8963c/attachment-0007.png>