[JIRA] (SSPCPP-975) Template attrChecker.html should guard use of target with shibmlpif

[Vlad Mencl (Jira)]

Vlad Mencl ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A9e33c654-fa34-43c9-a1c1-fcc1c32d3528 ) *created* an issue

Shibboleth SP - C++ ( https://shibboleth.atlassian.net/browse/SSPCPP?atlOrigin=eyJpIjoiYTBmN2E5MjJiMTg5NDYzZmJiMTc4NDI1MWYxM2ZkYzAiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/SSPCPP-975?atlOrigin=eyJpIjoiYTBmN2E5MjJiMTg5NDYzZmJiMTc4NDI1MWYxM2ZkYzAiLCJwIjoiaiJ9 ) SSPCPP-975 ( https://shibboleth.atlassian.net/browse/SSPCPP-975?atlOrigin=eyJpIjoiYTBmN2E5MjJiMTg5NDYzZmJiMTc4NDI1MWYxM2ZkYzAiLCJwIjoiaiJ9 ) Template attrChecker.html should guard use of target with shibmlpif ( https://shibboleth.atlassian.net/browse/SSPCPP-975?atlOrigin=eyJpIjoiYTBmN2E5MjJiMTg5NDYzZmJiMTc4NDI1MWYxM2ZkYzAiLCJwIjoiaiJ9 )

Issue Type: Improvement Affects Versions: 3.4.1 Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Configuration Created: 16/May/23 12:55 AM Priority: Trivial Reporter: Vlad Mencl ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A9e33c654-fa34-43c9-a1c1-fcc1c32d3528 )

Hi,

When experimenting with the Attribute-Checker handler, I found the /etc/shibboleth/attrChecker.html template tries to use the target parameter passed to the handler, which is however not visible to the template (as the Errors externalParameters setting, defaulting to false , suppresses the visibility).

I understand the attrChecker template requires substantial customization for real deployments anyway, but perhaps to avoid confusion, the default template could guard the paragraph using `<shibmlp target />` with <shibmplpif target> ?

Cheers,
Vlad

( https://shibboleth.atlassian.net/browse/SSPCPP-975#add-comment?atlOrigin=eyJpIjoiYTBmN2E5MjJiMTg5NDYzZmJiMTc4NDI1MWYxM2ZkYzAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/SSPCPP-975#add-comment?atlOrigin=eyJpIjoiYTBmN2E5MjJiMTg5NDYzZmJiMTc4NDI1MWYxM2ZkYzAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:6805d32 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230516/b65f884b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-c5026100-8461-4cd1-a658-85e333bbf115
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230516/b65f884b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-823b335c-9627-4f07-98bf-9ca681855d5e
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230516/b65f884b/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-4a41615c-f6aa-49d9-858b-e1eca8a5ed64
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230516/b65f884b/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-bc7df197-2789-42ae-8633-bc5dda4d090f
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230516/b65f884b/attachment-0007.png>