[java-idp-plugin-oidc-rp] branch main updated: Fix minor Javadoc warnings

Phil Smart philip.smart at jisc.ac.uk
Fri May 12 10:20:40 UTC 2023


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=c14d53082a09f3a53465c9a1f1cdf5eb854ca886

The following commit(s) were added to refs/heads/main by this push:
     new c14d530  Fix minor Javadoc warnings
c14d530 is described below

commit c14d53082a09f3a53465c9a1f1cdf5eb854ca886
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Fri May 12 11:20:38 2023 +0100

    Fix minor Javadoc warnings
    
     Does not affect the build
---
 .../shibboleth/idp/plugin/authn/oidc/rp/test/TestTokenHelper.java | 2 ++
 .../oidc/rp/impl/MockAsymmetricJOSEObjectCredentialResolver.java  | 2 ++
 .../oidc/rp/impl/OIDCRPFlowFromAuthenticationResponseTest.java    | 8 +++++++-
 3 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/idp-oidc-rp-api/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/test/TestTokenHelper.java b/idp-oidc-rp-api/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/test/TestTokenHelper.java
index 823a082..9da1fac 100644
--- a/idp-oidc-rp-api/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/test/TestTokenHelper.java
+++ b/idp-oidc-rp-api/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/test/TestTokenHelper.java
@@ -160,6 +160,8 @@ public final class TestTokenHelper {
      * 
      * @throws JOSEException on error.
      * @throws ParseException on error.
+     * 
+     * @return the created JWT
      */
     public static JWT createJWT(@Nonnull final JWTClaimsSet payload, @Nullable final JWSAlgorithm sigAlg, 
             @Nullable final JWEAlgorithm jweAlg, @Nullable final EncryptionMethod enc, 
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/MockAsymmetricJOSEObjectCredentialResolver.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/MockAsymmetricJOSEObjectCredentialResolver.java
index bf63dee..4075798 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/MockAsymmetricJOSEObjectCredentialResolver.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/MockAsymmetricJOSEObjectCredentialResolver.java
@@ -46,6 +46,8 @@ public class MockAsymmetricJOSEObjectCredentialResolver implements JOSEObjectCre
      * Constructor.
      *
      * @param keyIn the key rto create a credential for.
+     * @param kidIn the kid
+     * @param algIn the alg
      */
     public MockAsymmetricJOSEObjectCredentialResolver(final AsymmetricJWK keyIn, final String kidIn, 
             final JWEAlgorithm algIn) {
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/OIDCRPFlowFromAuthenticationResponseTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/OIDCRPFlowFromAuthenticationResponseTest.java
index b84bf9b..b853ab3 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/OIDCRPFlowFromAuthenticationResponseTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/OIDCRPFlowFromAuthenticationResponseTest.java
@@ -82,7 +82,13 @@ public class OIDCRPFlowFromAuthenticationResponseTest extends OIDCRPFlowTest {
         setMockProperties(mockProperties);
     }
     
-    /** Resume a flow using a default prc construction.*/
+    /** 
+     * Resume a flow using a default prc construction.
+     * 
+     * @return the prc
+     * 
+     * @throws Exception on error
+     */
     private ProfileRequestContext resumeBasicFlow() throws Exception {
         
         final var flowExecution = (FlowExecutionImpl)getFlowExecutionFactory()

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list