[JIRA] (JSATTR-13) mismatched comments
Jonathan Zhao (Jira)
jira at shibboleth.atlassian.net
Tue May 9 14:08:31 UTC 2023
Jonathan Zhao ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=625f0ac97be65e006933ec3b ) *created* an issue
Shibboleth Attribute Library - Java ( https://shibboleth.atlassian.net/browse/JSATTR?atlOrigin=eyJpIjoiMWQwZTU2NDg5YzEwNDNiMjkwMmFlNjcyZTI1ZWEzYmUiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JSATTR-13?atlOrigin=eyJpIjoiMWQwZTU2NDg5YzEwNDNiMjkwMmFlNjcyZTI1ZWEzYmUiLCJwIjoiaiJ9 ) JSATTR-13 ( https://shibboleth.atlassian.net/browse/JSATTR-13?atlOrigin=eyJpIjoiMWQwZTU2NDg5YzEwNDNiMjkwMmFlNjcyZTI1ZWEzYmUiLCJwIjoiaiJ9 ) mismatched comments ( https://shibboleth.atlassian.net/browse/JSATTR-13?atlOrigin=eyJpIjoiMWQwZTU2NDg5YzEwNDNiMjkwMmFlNjcyZTI1ZWEzYmUiLCJwIjoiaiJ9 )
Issue Type: Bug Assignee: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Components: Attribute Resolver Created: 09/May/23 10:08 AM Priority: Trivial Reporter: Jonathan Zhao ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=625f0ac97be65e006933ec3b )
/**
* Set the principal associated with this resolution.
*
* @return Returns the principal.
*/
@Nullable public String getPrincipal() {
return principal;
}
/**
* Get the principal associated with this resolution.
*
* @param who the principal to set.
*
* @return this context
*/
@Nonnull public AttributeResolutionContext setPrincipal(@Nullable final String who) {
principal = who;
return this;
}
The comments for "get/set" are mismatched with the getter/setter methods.
https://git.shibboleth.net/view/?p=java-shib-attribute.git;a=blob;f=shib-attribute-resolver-api/src/main/java/net/shibboleth/idp/attribute/resolver/context/AttributeResolutionContext.java;h=5221b5ef3ee85353fc3c7545b9e9dc41467c7bb1;hb=HEAD
( https://shibboleth.atlassian.net/browse/JSATTR-13#add-comment?atlOrigin=eyJpIjoiMWQwZTU2NDg5YzEwNDNiMjkwMmFlNjcyZTI1ZWEzYmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSATTR-13#add-comment?atlOrigin=eyJpIjoiMWQwZTU2NDg5YzEwNDNiMjkwMmFlNjcyZTI1ZWEzYmUiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:b79b7f6 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230509/23a2344e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-1575ab28-4de8-4f7e-9e78-545a1c12c403
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230509/23a2344e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-b5ba21f3-0499-482f-93dc-103588075344
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230509/23a2344e/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-2039040f-f82a-473c-830c-ce9ca91d467c
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230509/23a2344e/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-138120d4-3df4-422a-bf2b-27f875de2907
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230509/23a2344e/attachment-0007.png>
More information about the commits
mailing list