[java-identity-provider] branch main updated: IDP-2100 - Eliminate unnecessary message mapping for simpler login flows

Scott Cantor cantor.2 at osu.edu
Mon May 8 17:53:18 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=f0ebd71964ff65258a9d3d25544ba046f0c69783

The following commit(s) were added to refs/heads/main by this push:
     new f0ebd7196 IDP-2100 - Eliminate unnecessary message mapping for simpler login flows
f0ebd7196 is described below

commit f0ebd71964ff65258a9d3d25544ba046f0c69783
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon May 8 13:53:14 2023 -0400

    IDP-2100 - Eliminate unnecessary message mapping for simpler login flows
    
    https://shibboleth.atlassian.net/browse/IDP-2100
    
    Eliminated Function module.
---
 .../shibboleth/idp/module/authn/impl/Function.java | 41 ----------------------
 .../services/net.shibboleth.idp.module.IdPModule   |  1 -
 .../idp/module/authn/impl/module.properties        |  7 ----
 .../module/conf/authn/function-authn-config.xml    | 34 ------------------
 4 files changed, 83 deletions(-)

diff --git a/idp-conf-impl/src/main/java/net/shibboleth/idp/module/authn/impl/Function.java b/idp-conf-impl/src/main/java/net/shibboleth/idp/module/authn/impl/Function.java
deleted file mode 100644
index ca6fc18ca..000000000
--- a/idp-conf-impl/src/main/java/net/shibboleth/idp/module/authn/impl/Function.java
+++ /dev/null
@@ -1,41 +0,0 @@
-/*
- * Licensed to the University Corporation for Advanced Internet Development,
- * Inc. (UCAID) under one or more contributor license agreements.  See the
- * NOTICE file distributed with this work for additional information regarding
- * copyright ownership. The UCAID licenses this file to You under the Apache
- * License, Version 2.0 (the "License"); you may not use this file except in
- * compliance with the License.  You may obtain a copy of the License at
- *
- *    http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package net.shibboleth.idp.module.authn.impl;
-
-import java.io.IOException;
-
-import net.shibboleth.idp.module.IdPModule;
-import net.shibboleth.idp.module.ModuleException;
-import net.shibboleth.idp.module.impl.CoreIdPModule;
-
-/**
- * {@link IdPModule} implementation.
- */
-public final class Function extends CoreIdPModule {
-
-    /**
-     * Constructor.
-     *  
-     * @throws ModuleException on error
-     * @throws IOException on error
-     */
-    public Function() throws IOException, ModuleException {
-        super(Function.class);
-    }
-
-}
\ No newline at end of file
diff --git a/idp-conf-impl/src/main/resources/META-INF/services/net.shibboleth.idp.module.IdPModule b/idp-conf-impl/src/main/resources/META-INF/services/net.shibboleth.idp.module.IdPModule
index 6732df8e7..e4c052728 100644
--- a/idp-conf-impl/src/main/resources/META-INF/services/net.shibboleth.idp.module.IdPModule
+++ b/idp-conf-impl/src/main/resources/META-INF/services/net.shibboleth.idp.module.IdPModule
@@ -1,5 +1,4 @@
 net.shibboleth.idp.module.authn.impl.Duo
-net.shibboleth.idp.module.authn.impl.Function
 net.shibboleth.idp.module.authn.impl.IPAddress
 net.shibboleth.idp.module.authn.impl.MFA
 net.shibboleth.idp.module.authn.impl.Password
diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/authn/impl/module.properties b/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/authn/impl/module.properties
index 94d9a2612..fc6f2a9e1 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/authn/impl/module.properties
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/authn/impl/module.properties
@@ -2,7 +2,6 @@
 
 # Class to Module ID mappings
 net.shibboleth.idp.module.authn.impl.Duo = idp.authn.Duo
-net.shibboleth.idp.module.authn.impl.Function = idp.authn.Function
 net.shibboleth.idp.module.authn.impl.IPAddress = idp.authn.IPAddress
 net.shibboleth.idp.module.authn.impl.MFA = idp.authn.MFA
 net.shibboleth.idp.module.authn.impl.Password = idp.authn.Password
@@ -21,12 +20,6 @@ idp.authn.Duo.2.dest = conf/authn/duo.properties
 idp.authn.Duo.3.src = /net/shibboleth/idp/module/views/duo.vm
 idp.authn.Duo.3.dest = views/duo.vm
 
-idp.authn.Function.name = Function Authentication
-idp.authn.Function.desc = Login flow that produces a result from a function.
-idp.authn.Function.url = /FunctionAuthnConfiguration
-idp.authn.Function.1.src = /net/shibboleth/idp/module/conf/authn/function-authn-config.xml
-idp.authn.Function.1.dest = conf/authn/function-authn-config.xml
-
 idp.authn.IPAddress.name = IPAddress Authentication
 idp.authn.IPAddress.desc = Login flow that maps IP Address ranges to subjects.
 idp.authn.IPAddress.url = /IPAddressAuthnConfiguration
diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/authn/function-authn-config.xml b/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/authn/function-authn-config.xml
deleted file mode 100644
index 636fec5f0..000000000
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/authn/function-authn-config.xml
+++ /dev/null
@@ -1,34 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<beans xmlns="http://www.springframework.org/schema/beans"
-       xmlns:context="http://www.springframework.org/schema/context"
-       xmlns:util="http://www.springframework.org/schema/util"
-       xmlns:p="http://www.springframework.org/schema/p"
-       xmlns:c="http://www.springframework.org/schema/c"
-       xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-       xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd
-                           http://www.springframework.org/schema/context http://www.springframework.org/schema/context/spring-context.xsd
-                           http://www.springframework.org/schema/util http://www.springframework.org/schema/util/spring-util.xsd"
-                           
-       default-init-method="initialize"
-       default-destroy-method="destroy">
-
-    <!--
-    The entire flow depends on the execution of a function bean you supply. A pathological script example
-    is below. The function may return a String, Principal, Subject, or a null to signal failure.
-    
-    You may also raise an exception and install a bean named shibboleth.authn.Function.ClassifiedMessageMap
-    to map exception messages to events.
-    -->
-    
-    <bean id="shibboleth.authn.Function.ResultLookupStrategy"
-            parent="shibboleth.ContextFunctions.Scripted" factory-method="inlineScript">
-        <constructor-arg>
-            <value>
-            <![CDATA[
-                null;
-            ]]>
-            </value>
-        </constructor-arg>
-    </bean>    
-
-</beans>

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list