[java-identity-provider] branch main updated: IDP-2100 - Eliminate unnecessary message mapping for simpler login flows

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=653136d50a5fb90cbd2026423ca618b933e0a113

The following commit(s) were added to refs/heads/main by this push:
     new 653136d50 IDP-2100 - Eliminate unnecessary message mapping for simpler login flows
653136d50 is described below

commit 653136d50a5fb90cbd2026423ca618b933e0a113
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon May 8 10:11:39 2023 -0400

    IDP-2100 - Eliminate unnecessary message mapping for simpler login flows
    
    https://shibboleth.atlassian.net/browse/IDP-2100
    
    Add a rule for InvalidCredentials to match RemoteUserInternal.
    Revert addition of failure auditing on NoCredentials event.
---
 .../net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java    | 1 -
 .../resources/net/shibboleth/idp/flows/authn/remoteuser-authn-flow.xml   | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
index 9007cb0af..488153709 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ValidateExternalAuthentication.java
@@ -203,7 +203,6 @@ public class ValidateExternalAuthentication extends AbstractAuditingValidationAc
                     getLogPrefix());
             handleError(profileRequestContext, authenticationContext, AuthnEventIds.NO_CREDENTIALS,
                     AuthnEventIds.NO_CREDENTIALS);
-            recordFailure(profileRequestContext);
             return;
         }
         final Subject subject = extContext.getSubject();
diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/remoteuser-authn-flow.xml b/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/remoteuser-authn-flow.xml
index de4fc42a9..4ce75ebcc 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/remoteuser-authn-flow.xml
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/flows/authn/remoteuser-authn-flow.xml
@@ -31,6 +31,7 @@
 
         <transition on="proceed" to="CallSubjectCanonicalization" />
         <transition on="NoCredentials" to="ReselectFlow" />
+        <transition on="InvalidCredentials" to="ReselectFlow" />
     </action-state>
 
     <!-- This runs a c14n step on the result of the authentication. -->

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.