[JIRA] (OSJ-362) Add support for dynamic config to Decrypter

Brent Putman (Jira) jira at shibboleth.atlassian.net
Fri May 5 02:42:22 UTC 2023


Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) *commented* on OSJ-362 ( https://shibboleth.atlassian.net/browse/OSJ-362?atlOrigin=eyJpIjoiYTU3ZDliMmM2NTE2NDMwMTg3YTM2ZDFlMmZmYmVkZjciLCJwIjoiaiJ9 )

Re: Add support for dynamic config to Decrypter ( https://shibboleth.atlassian.net/browse/OSJ-362?atlOrigin=eyJpIjoiYTU3ZDliMmM2NTE2NDMwMTg3YTM2ZDFlMmZmYmVkZjciLCJwIjoiaiJ9 )

Note that Decrypter is already a per-use prototype-y object, configured with data for each decryption operation. So I think the way to handle this is to move the recipients from statically configured data on the EncryptedKeyResolver instances, to data that is set on the Decrypter and passed to the resolver at decryption time.

Tentative plan is:

* make Set<String> recipients an arg to EncryptedKeyResolver#resolve(...)

* update impls accordingly
* deprecate or remove existing getRecipients() method

* add Set<String> recipients field to Decrypter

* populate-able via:

* DecryptionParameters via existing convenience ctor
* other overloaded ctors

* Decrypter passes these into EncryptedKeyResolver when the latter is called

* update DecryptionParametersResolver to resolve recipients onto params

* how this actually works needs to be determined

* must it be configured on DecryptionConfiguration vs some other criteria vs uses strategy function vs other ?

* update AbstractDecryptAction to just use ctor taking DecryptionParameters instead of individual params

I think we’re ok design-wise on encryption, as the recipients are already just part of the data passed via KeyEncryptionParameters. We may need to look at how the recipients are actually resolved and populated on there.

( https://shibboleth.atlassian.net/browse/OSJ-362#add-comment?atlOrigin=eyJpIjoiYTU3ZDliMmM2NTE2NDMwMTg3YTM2ZDFlMmZmYmVkZjciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-362#add-comment?atlOrigin=eyJpIjoiYTU3ZDliMmM2NTE2NDMwMTg3YTM2ZDFlMmZmYmVkZjciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:f83bc8f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230505/7db8fcd3/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-ce3e1ecd-ff56-4a09-8c66-f57f82f644c7
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230505/7db8fcd3/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a5c329fe-d00e-48de-b1ea-9865c70ec947
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230505/7db8fcd3/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-2b43edb5-d528-4a3d-8bc0-92e633e0ef0a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230505/7db8fcd3/attachment-0005.png>


More information about the commits mailing list