[JIRA] (IDP-2002) Non-module configuration file should also generate *.idpnew for convenience when upgrading

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2002 ( https://shibboleth.atlassian.net/browse/IDP-2002?atlOrigin=eyJpIjoiZjkwMTNlNzRkNGM1NDRlNDhlNzIwNzc4NjRiNjY4MWMiLCJwIjoiaiJ9 )

Re: Non-module configuration file should also generate *.idpnew for convenience when upgrading ( https://shibboleth.atlassian.net/browse/IDP-2002?atlOrigin=eyJpIjoiZjkwMTNlNzRkNGM1NDRlNDhlNzIwNzc4NjRiNjY4MWMiLCJwIjoiaiJ9 )

It’s next up in my queue. The downside continues to be the test implications. It creates a situation where the copy of the files under src/test/resources could fall out of sync with the core files and we’d not know the tests were only working artificially.

OTOH, the actual set of files that are not in src/test/resources now is getting smaller and smaller, so I think we already essentially have this problem independently of this change. There are lots of and lots of “just for the tests” changes now.

What I do not want is any situation where I’m encouraged by lazyness to keep editing the “real” files to test things, because that leads to accidental commits and regressions as we just had recently. This change wouldn’t directly make that worse, but auto-copying the originals into place to run the tests would.

Maybe a middle ground would be…we implement by default a process that copies the files into place for testing overtop of anything in src/test/resources but we also implement it in some way that would protect existing files there. Which…sounds an awful lot like the reverse of the normal module process where existing files don’t get touched.

I guess in effect what we need is to implement the tests to copy a base set of files out of our conf-impl set (which is always the real stuff), then overlay those with a test set of files. And then point idp.home at that tree rather than the classpath. Maybe in the aggregate that’s even a better model than now, since it’s more “real”, but it also means we lose the constant exercising of the classpath: trick. Which may be good or bad.

I guess we can discuss Friday.

( https://shibboleth.atlassian.net/browse/IDP-2002#add-comment?atlOrigin=eyJpIjoiZjkwMTNlNzRkNGM1NDRlNDhlNzIwNzc4NjRiNjY4MWMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2002#add-comment?atlOrigin=eyJpIjoiZjkwMTNlNzRkNGM1NDRlNDhlNzIwNzc4NjRiNjY4MWMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:f83bc8f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/d77cd17a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-eb370d24-63c2-4087-9913-7357043b559a
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/d77cd17a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-43bdbffc-97f9-4704-b6cc-9a97eab95cfe
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/d77cd17a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-90fa0bdb-da62-47d1-946b-9c7539c27a17
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/d77cd17a/attachment-0005.png>