[JIRA] (JSSH-27) Implement an ensureId method to help with nullability annotation

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Thu May 4 15:28:03 UTC 2023


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on JSSH-27 ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiNGVjMmFiYzQzM2ViNGExYzhhOThkMDc3MjM2M2NkZDAiLCJwIjoiaiJ9 )

Re: Implement an ensureId method to help with nullability annotation ( https://shibboleth.atlassian.net/browse/JSSH-27?atlOrigin=eyJpIjoiNGVjMmFiYzQzM2ViNGExYzhhOThkMDc3MjM2M2NkZDAiLCJwIjoiaiJ9 )

A couple of Interfaces which could do with an ensureId are

net.shibboleth.idp.session.IdPSession
net.shibboleth.idp.session.SPSession

There's a log of defensive asserts in the packages net.shibboleth.idp.session.impl around their getId methods

( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiNGVjMmFiYzQzM2ViNGExYzhhOThkMDc3MjM2M2NkZDAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-27#add-comment?atlOrigin=eyJpIjoiNGVjMmFiYzQzM2ViNGExYzhhOThkMDc3MjM2M2NkZDAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:f83bc8f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/7d85eeb8/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5425495d-f72b-489b-8177-7a95604d07c1
Type: image/png
Size: 302 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/7d85eeb8/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-9f9fdd52-3d42-4aa9-bc64-05b0f8982a4b
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/7d85eeb8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-8b2b4ccd-a0bc-4579-9920-cdb6885a48d5
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/7d85eeb8/attachment-0005.png>


More information about the commits mailing list