[JIRA] (JSSH-29) Add a @NonnullBeforeTest annotation

Rod Widdowson (Jira) jira at shibboleth.atlassian.net
Thu May 4 14:46:38 UTC 2023


Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *closed* an issue as *Done*

This is done. I have added the annotation and am adding it to the test code as I work over it for other (null squashing) reasons.

In tests the paradigm I'm mostly ending up with is

* Add the annotation (as documentation)
* Adding individual asserts or (if we need more than one)
* Adding a @Nonnull Thing getThingInTest() method and using that

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiMDU3ZGZkM2JiZjZkNDUxNGExYjE0YWNlNDM3YTc0ODUiLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JSSH-29?atlOrigin=eyJpIjoiMDU3ZGZkM2JiZjZkNDUxNGExYjE0YWNlNDM3YTc0ODUiLCJwIjoiaiJ9 ) JSSH-29 ( https://shibboleth.atlassian.net/browse/JSSH-29?atlOrigin=eyJpIjoiMDU3ZGZkM2JiZjZkNDUxNGExYjE0YWNlNDM3YTc0ODUiLCJwIjoiaiJ9 ) Add a @NonnullBeforeTest annotation ( https://shibboleth.atlassian.net/browse/JSSH-29?atlOrigin=eyJpIjoiMDU3ZGZkM2JiZjZkNDUxNGExYjE0YWNlNDM3YTc0ODUiLCJwIjoiaiJ9 )

Change By: Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) Resolution: Done Status: Open Closed Remaining Estimate: 0 minutes Time Spent: 30 minutes

( https://shibboleth.atlassian.net/browse/JSSH-29#add-comment?atlOrigin=eyJpIjoiMDU3ZGZkM2JiZjZkNDUxNGExYjE0YWNlNDM3YTc0ODUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-29#add-comment?atlOrigin=eyJpIjoiMDU3ZGZkM2JiZjZkNDUxNGExYjE0YWNlNDM3YTc0ODUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:f83bc8f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/60cdf071/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a9f1d5ea-7b03-4cb2-acb4-d42a193e358d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/60cdf071/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a7be2875-5a11-4e09-914c-c59826ff9197
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/60cdf071/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f0c0e5c8-0bfb-46b8-a2eb-845432b62804
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/60cdf071/attachment-0005.png>


More information about the commits mailing list