[JIRA] (IDP-2044) Scripted object constructors and initialization
Scott Cantor (Jira)
jira at shibboleth.atlassian.net
Thu May 4 14:36:06 UTC 2023
Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2044 ( https://shibboleth.atlassian.net/browse/IDP-2044?atlOrigin=eyJpIjoiMzc1Yzg1NjRmMGUzNDI3YmEzMThhZGMzOWI1YzQyMjkiLCJwIjoiaiJ9 )
Re: Scripted object constructors and initialization ( https://shibboleth.atlassian.net/browse/IDP-2044?atlOrigin=eyJpIjoiMzc1Yzg1NjRmMGUzNDI3YmEzMThhZGMzOWI1YzQyMjkiLCJwIjoiaiJ9 )
There’s also the issue of why so much of this was done with factory methods, which really only make sense when they’re isolated from the class type they’re creating, which is not the case here. But there’s too much customer qiring depending on that so I think the overall change may just be checking over all the interlocking methods for mistakes, and adding factory methods to classes that don’t already have them for consistency.
( https://shibboleth.atlassian.net/browse/IDP-2044#add-comment?atlOrigin=eyJpIjoiMzc1Yzg1NjRmMGUzNDI3YmEzMThhZGMzOWI1YzQyMjkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2044#add-comment?atlOrigin=eyJpIjoiMzc1Yzg1NjRmMGUzNDI3YmEzMThhZGMzOWI1YzQyMjkiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:f83bc8f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/a96d5b1e/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-e1bb2c9c-c921-4a36-a828-d8eae65cb077
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/a96d5b1e/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-fc848ed5-fdc5-4e68-be77-a412b68e4a64
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/a96d5b1e/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-9c814064-65df-4ff4-b298-859da8aa7354
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230504/a96d5b1e/attachment-0005.png>
More information about the commits
mailing list