[java-oidc-common] branch main updated: Change INFO level logging to DEBUG. Improve logging

Phil Smart philip.smart at jisc.ac.uk
Tue May 2 17:54:32 UTC 2023


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=7d234dff46dc7df487b250d37a34e15557aa052e

The following commit(s) were added to refs/heads/main by this push:
     new 7d234df  Change INFO level logging to DEBUG. Improve logging
7d234df is described below

commit 7d234dff46dc7df487b250d37a34e15557aa052e
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue May 2 18:54:29 2023 +0100

    Change INFO level logging to DEBUG. Improve logging
    
            - Avoid some log clutter on INFO
---
 .../net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java   | 4 +++-
 .../net/shibboleth/oidc/metadata/cache/impl/DynamicMetadataCache.java | 2 +-
 .../oidc/metadata/impl/AbstractDynamicHTTPFetchingStrategy.java       | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java
index 7846ef1..7e9fa65 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java
@@ -42,6 +42,7 @@ import com.nimbusds.jose.crypto.MACVerifier;
 import com.nimbusds.jose.crypto.RSASSAVerifier;
 import com.nimbusds.jwt.SignedJWT;
 
+import net.shibboleth.oidc.security.CredentialConversionUtil;
 import net.shibboleth.oidc.security.credential.JOSEObjectCredentialResolver;
 import net.shibboleth.oidc.security.credential.JWKCredential;
 import net.shibboleth.oidc.security.jose.criterion.JOSEObjectCriterion;
@@ -182,7 +183,8 @@ public abstract class BaseSignedJWTTrustEngine<TrustBasisType> implements TrustE
                 log.debug("Signature validation using candidate credential was successful");
                 return true;
             }
-            log.debug("Unable to validate given JWT with credential");
+            log.debug("Unable to validate given JWT with credential '{}'", 
+                    CredentialConversionUtil.resolveKid(credential));
             return false;
         } catch (final JOSEException | IllegalStateException e) {
             final String kid = credential instanceof JWKCredential ?
diff --git a/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/cache/impl/DynamicMetadataCache.java b/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/cache/impl/DynamicMetadataCache.java
index 5334eee..bf2d0a4 100644
--- a/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/cache/impl/DynamicMetadataCache.java
+++ b/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/cache/impl/DynamicMetadataCache.java
@@ -541,7 +541,7 @@ public class DynamicMetadataCache<IdentifierType, MetadataType>
         log.debug("{} Computed metadata '{}' refresh trigger time: {}", getLogPrefix(), 
                 extractedIdentifier, mgmtData.getRefreshTriggerTime());
         
-        log.info("{} Successfully loaded new Metadata with identifer '{}'", getLogPrefix(), extractedIdentifier);   
+        log.debug("{} Successfully loaded new Metadata with identifer '{}'", getLogPrefix(), extractedIdentifier);   
     }
     
     /**
diff --git a/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/AbstractDynamicHTTPFetchingStrategy.java b/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/AbstractDynamicHTTPFetchingStrategy.java
index d33b306..2725292 100644
--- a/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/AbstractDynamicHTTPFetchingStrategy.java
+++ b/oidc-common-metadata-impl/src/main/java/net/shibboleth/oidc/metadata/impl/AbstractDynamicHTTPFetchingStrategy.java
@@ -204,7 +204,7 @@ public abstract class AbstractDynamicHTTPFetchingStrategy<MetadataType>
 
     @Override
     @Nullable public MetadataType apply(@Nonnull final CriteriaSet criteria) {
-        log.info("{} fetching metadata based on criteria: {}", getId(), criteria);
+        log.debug("{} fetching metadata based on criteria: {}", getId(), criteria);
         final HttpUriRequest request = buildHttpRequest(criteria);
         if (request == null) {
             log.debug("Could not build request based on input criteria, unable to query");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list