[java-shib-shared] branch main updated: Widen test

[Rod Widdowson]

This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-shib-shared.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-shared.git;a=commit;h=27acfe373cc9846769036907c798e8eadb75f267

The following commit(s) were added to refs/heads/main by this push:
     new 27acfe37 Widen test
27acfe37 is described below

commit 27acfe373cc9846769036907c798e8eadb75f267
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Mon May 1 17:11:58 2023 +0100

    Widen test
    
    minr fix to javadoc
---
 .../src/main/java/net/shibboleth/shared/xml/AttributeSupport.java     | 2 +-
 .../src/test/java/net/shibboleth/shared/xml/AttributeSupportTest.java | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java b/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java
index 9af31bc5..f0837609 100644
--- a/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java
+++ b/shib-support/src/main/java/net/shibboleth/shared/xml/AttributeSupport.java
@@ -242,7 +242,7 @@ public final class AttributeSupport {
      * @param element element that may contain the attribute, may be null
      * @param attributeName name of the attribute, may be null
      * 
-     * @return the attribute or null if the given element or attribute was null or the given attribute did not contain
+     * @return the attribute or null if the given element or attribute was null or the given element did not contain
      *         an attribute with the given name
      */
     @Nullable public static Attr getAttribute(@Nonnull final Element element, @Nonnull final QName attributeName) {
diff --git a/shib-support/src/test/java/net/shibboleth/shared/xml/AttributeSupportTest.java b/shib-support/src/test/java/net/shibboleth/shared/xml/AttributeSupportTest.java
index ac97b058..1bbfa9b6 100644
--- a/shib-support/src/test/java/net/shibboleth/shared/xml/AttributeSupportTest.java
+++ b/shib-support/src/test/java/net/shibboleth/shared/xml/AttributeSupportTest.java
@@ -692,8 +692,10 @@ public class AttributeSupportTest {
         //
         // This case is weird
         //
-        final String s= attributes.getAttributeNS(TEST_NS, "testAttrNonExist");
+        String s= attributes.getAttributeNS(TEST_NS, "testAttrNonExist");
         assert "".equals(s);
+        s = AttributeSupport.getAttributeValue(attributes, TEST_NS, "testAttrNonExist");
+        assert s == null;
     }
 
     private <T> T nullValue() {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.