[JIRA] (IDP-2083) Treat NonnullElements as the default for collections

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Identity Provider ( https://shibboleth.atlassian.net/browse/IDP?atlOrigin=eyJpIjoiMmQxOWE0MzMxMzdiNDJlNWIyNDA5NTBjZDk0OWU1MDMiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/IDP-2083?atlOrigin=eyJpIjoiMmQxOWE0MzMxMzdiNDJlNWIyNDA5NTBjZDk0OWU1MDMiLCJwIjoiaiJ9 ) IDP-2083 ( https://shibboleth.atlassian.net/browse/IDP-2083?atlOrigin=eyJpIjoiMmQxOWE0MzMxMzdiNDJlNWIyNDA5NTBjZDk0OWU1MDMiLCJwIjoiaiJ9 ) Treat NonnullElements as the default for collections ( https://shibboleth.atlassian.net/browse/IDP-2083?atlOrigin=eyJpIjoiMmQxOWE0MzMxMzdiNDJlNWIyNDA5NTBjZDk0OWU1MDMiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Unassigned Created: 29/Mar/23 12:37 PM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

I suggested we consider reversing our approach with this annotation and deprecating it. Instead, we should define a NullElements variant and use that to mark any collections that violate the usual convention of disallowing nulls, which should be relatively few.

None of this affects our builds or static analyzer so it is a manual task and only testable via unit tests.

( https://shibboleth.atlassian.net/browse/IDP-2083#add-comment?atlOrigin=eyJpIjoiMmQxOWE0MzMxMzdiNDJlNWIyNDA5NTBjZDk0OWU1MDMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2083#add-comment?atlOrigin=eyJpIjoiMmQxOWE0MzMxMzdiNDJlNWIyNDA5NTBjZDk0OWU1MDMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/ab190bc0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a9596293-3eb1-49cc-afee-6c33545cd413
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/ab190bc0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-859f5cd9-30e0-4e34-a5fa-c0a9fb9057a8
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/ab190bc0/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-789b471c-042c-4a63-aeeb-4d5f804df063
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/ab190bc0/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-166eccd5-49d2-4a22-a3fc-e8ed384debc8
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/ab190bc0/attachment-0007.png>