[JIRA] (MDA-281) Remove ComponentInfo system

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Metadata Aggregator ( https://shibboleth.atlassian.net/browse/MDA?atlOrigin=eyJpIjoiZGVjNDRiY2IyODI1NDRjMzk0ZDM4ZDA4YjM4YzEzZmYiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/MDA-281?atlOrigin=eyJpIjoiZGVjNDRiY2IyODI1NDRjMzk0ZDM4ZDA4YjM4YzEzZmYiLCJwIjoiaiJ9 ) MDA-281 ( https://shibboleth.atlassian.net/browse/MDA-281?atlOrigin=eyJpIjoiZGVjNDRiY2IyODI1NDRjMzk0ZDM4ZDA4YjM4YzEzZmYiLCJwIjoiaiJ9 ) Remove ComponentInfo system ( https://shibboleth.atlassian.net/browse/MDA-281?atlOrigin=eyJpIjoiZGVjNDRiY2IyODI1NDRjMzk0ZDM4ZDA4YjM4YzEzZmYiLCJwIjoiaiJ9 )

Issue Type: Improvement Affects Versions: 0.9.2 Assignee: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) Components: Pipeline Created: 29/Mar/23 6:48 AM Fix Versions: 0.10.0 Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

The MDA includes a mechanism which was originally intended to aid in performance monitoring, but which doesn’t do a very good job of that and as a result is probably entirely unused.

The mechanism is that SimplePipeline and AbstractStage unconditionally create a ComponentInfo instance to the item metadata of every item that passes through them. This is two timestamp calls and an object creation for every item passed through every stage, plus more object creation when the ComponentInfo instances are added to the item metadata collections. This seems quite expensive for something that is never used, and can’t be turned off. We should just abolish it for 0.10.

I’ll create separate tickets for replacement mechanisms; I can think of two approaches that might make sense. One is a specific mechanism in CompositeStage and SimplePipeline to optionally log progress (but not record it in the items). I have a mockup of this and I think it makes sense for 0.10. It also makes sense to look into a more targeted mechanism based on a hook for something like Metrics or Micrometer (the IdP uses the former, I think, while Spring Framework has some kind of relationship with the latter) but I have less of an idea as to the form that might take.

( https://shibboleth.atlassian.net/browse/MDA-281#add-comment?atlOrigin=eyJpIjoiZGVjNDRiY2IyODI1NDRjMzk0ZDM4ZDA4YjM4YzEzZmYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-281#add-comment?atlOrigin=eyJpIjoiZGVjNDRiY2IyODI1NDRjMzk0ZDM4ZDA4YjM4YzEzZmYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/cb6e72f6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-fcfac2b5-e548-43de-bdba-b0f140421738
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/cb6e72f6/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-24988f57-a763-4751-9315-5c0976a8d3b0
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/cb6e72f6/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-55d957d0-e9c7-4400-a7a6-3814dbd8cae9
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/cb6e72f6/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6ffc4bce-bb08-4723-9da9-e64477fcf08c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/cb6e72f6/attachment-0007.png>