[JIRA] (MDA-276) Unify SimplePipeline and CompositeStage

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *commented* on MDA-276 ( https://shibboleth.atlassian.net/browse/MDA-276?atlOrigin=eyJpIjoiMmFlMGQ5ZGNlN2UxNDYwY2E0OGIwN2U2Y2YyYTk3ZDkiLCJwIjoiaiJ9 )

Re: Unify SimplePipeline and CompositeStage ( https://shibboleth.atlassian.net/browse/MDA-276?atlOrigin=eyJpIjoiMmFlMGQ5ZGNlN2UxNDYwY2E0OGIwN2U2Y2YyYTk3ZDkiLCJwIjoiaiJ9 )

I think it’s fairly clear that the property should become stages for both: this means changing the API for CompositeStage and it makes sense to do that with a deprecation notice initially.

The next point of comparison is the execute method: in Pipeline that throws PipelineProcessingException while in Stage we have StageProcessingException which is a subclass. There are no other subclasses of PipelineProcessingException so it’s not clear that we need to have both.

The other main difference between Pipeline and Stage is that Pipeline includes a getter for the stages property. It doesn’t have a setter, but perhaps that’s fine: if we continue to use Pipeline as a marker for “a thing that is made up of stages you can execute” then it doesn’t need one.

Pipeline (the interface) is what the CLI uses when it’s looking up the pipeline to run.

If we can reconcile the exception hierarchy, I think we can end up with CompositeStage implementing Pipeline and SimplePipeline being an empty subtype of CompositeStage.

( https://shibboleth.atlassian.net/browse/MDA-276#add-comment?atlOrigin=eyJpIjoiMmFlMGQ5ZGNlN2UxNDYwY2E0OGIwN2U2Y2YyYTk3ZDkiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-276#add-comment?atlOrigin=eyJpIjoiMmFlMGQ5ZGNlN2UxNDYwY2E0OGIwN2U2Y2YyYTk3ZDkiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:6a6077b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/3f7eb499/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-95f5ad13-4ec9-478b-a5f8-53be9ae92328
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/3f7eb499/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-580d9f00-7acb-424d-9362-ae92f616e873
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/3f7eb499/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-d02728ae-8632-456d-af3f-308f58bd2a0a
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230329/3f7eb499/attachment-0005.png>