[JIRA] (MDA-280) EntityDescriptorItemIdPopulationStage can issue ConstraintViolation at run time with bad data

[Ian Young (Jira)]

Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) *created* an issue

Metadata Aggregator ( https://shibboleth.atlassian.net/browse/MDA?atlOrigin=eyJpIjoiZTliZTNlZGY4YTI4NDY3NDhlYmFjMWJlMWUxZjVmZjYiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/MDA-280?atlOrigin=eyJpIjoiZTliZTNlZGY4YTI4NDY3NDhlYmFjMWJlMWUxZjVmZjYiLCJwIjoiaiJ9 ) MDA-280 ( https://shibboleth.atlassian.net/browse/MDA-280?atlOrigin=eyJpIjoiZTliZTNlZGY4YTI4NDY3NDhlYmFjMWJlMWUxZjVmZjYiLCJwIjoiaiJ9 ) EntityDescriptorItemIdPopulationStage can issue ConstraintViolation at run time with bad data ( https://shibboleth.atlassian.net/browse/MDA-280?atlOrigin=eyJpIjoiZTliZTNlZGY4YTI4NDY3NDhlYmFjMWJlMWUxZjVmZjYiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 0.9.2 Assignee: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) Components: SAML Metadata Created: 27/Mar/23 10:54 AM Fix Versions: 0.10.0 Priority: Trivial Reporter: Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 )

EntityDescriptorItemIdPopulationStage will throw a constraint violation exception at run time with bad data:

* An EntityDescriptor lacking an entityID attribute entirely,
* An EntityDescriptor whose entityID is an empty string.

Neither of these situations is schema-valid ( entityID is use="required" and of type anyURI , so must be present and cannot be empty) but an exception is probably the wrong result as it will terminate the whole pipeline.

This probably isn’t reachable by most deployers as a bad entityID would be caught by schema validation in most deployments.

One option would be to turn this into an ErrorStatus , but I’m wary of doing that for something that isn’t an intentional check.

A reasonable alternative would be to treat it in the same way as the stage currently treats an item which isn’t an EntityDescriptor , and just complete silently.

( https://shibboleth.atlassian.net/browse/MDA-280#add-comment?atlOrigin=eyJpIjoiZTliZTNlZGY4YTI4NDY3NDhlYmFjMWJlMWUxZjVmZjYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/MDA-280#add-comment?atlOrigin=eyJpIjoiZTliZTNlZGY4YTI4NDY3NDhlYmFjMWJlMWUxZjVmZjYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:0152477 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/e18c1c47/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-f2ae880e-1b99-4577-b2b3-ae8c3f8dd5bf
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/e18c1c47/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-d5f17933-ecdb-4634-9daf-b189ff0a71e2
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/e18c1c47/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-cf0cb74c-0219-4bce-9f44-e9f3a4e87e66
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/e18c1c47/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-b4c0a63f-ecd4-43c9-8be9-0a18adde3158
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/e18c1c47/attachment-0007.png>