[JIRA] (JCOMOIDC-66) Review ProfileConfiguration interfaces and concrete classes

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-66 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiMmJlYTgxNzZhYmVkNDFkM2JmOTlkMGU4NWQ1OGZlZmMiLCJwIjoiaiJ9 )

Re: Review ProfileConfiguration interfaces and concrete classes ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiMmJlYTgxNzZhYmVkNDFkM2JmOTlkMGU4NWQ1OGZlZmMiLCJwIjoiaiJ9 )

I took another go at this, other than changes to test classes (that actually instantiate the concrete classes), I’ve now got to a point where the only change would be to the profile configuration XML e.g.

<bean id="OIDC.SSO" parent="AbstractOIDCSSOProfile" lazy-init="true"
       class="net.shibboleth.oidc.profile.config.OIDCAuthorizationConfiguration" 

to:

<bean id="OIDC.SSO" parent="AbstractOIDCSSOProfile" lazy-init="true"
       class="net.shibboleth.oidc.profile.config.impl.DefaultOIDCAuthorizationConfiguration" 

Similarly for the other profile configs. The interfaces should now replace all the old concrete classes (in addition to new interfaces) — although I need to dbl with some failing OP tests.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiMmJlYTgxNzZhYmVkNDFkM2JmOTlkMGU4NWQ1OGZlZmMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiMmJlYTgxNzZhYmVkNDFkM2JmOTlkMGU4NWQ1OGZlZmMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:0152477 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/7d4c7982/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-eae8e2b8-9a64-4d13-898f-864ef14b5fe4
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/7d4c7982/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4c2a76cd-ada1-4a36-8784-a4c67f9bf9ca
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/7d4c7982/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-38e8779a-a0a2-4721-824a-34b65b21f407
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230327/7d4c7982/attachment-0005.png>