[JIRA] (JCOMOIDC-66) Review ProfileConfiguration interfaces and concrete classes

[Philip Smart (Jira)]

Philip Smart ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=5afecdc1eb3ffa0c596652c4 ) *commented* on JCOMOIDC-66 ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiY2JhMjVhMzU5OTI1NGI4OWEyOTRjY2ExODgxOGExMmUiLCJwIjoiaiJ9 )

Re: Review ProfileConfiguration interfaces and concrete classes ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66?atlOrigin=eyJpIjoiY2JhMjVhMzU5OTI1NGI4OWEyOTRjY2ExODgxOGExMmUiLCJwIjoiaiJ9 )

I’ve pushed the latest version to the branch. At certain layers, the number of interfaces is a bit crazy. They exist to decompose the methods in a compatible way with how the classes are laid out (and what we are trying to achieve). That said, as it stands compatibility with older OPs is broken because I’ve moved things to the -impl package and some of the -api interfaces have different names. I will look at that next week.

Most of my struggle has been separating the AbstractOIDCSSOConfiguration and OIDCAuthorizationConfiguration classes. What is there seems to functionally work using the new OIDCAuthenticationRelyingPartyProfileConfiguration and OIDCAuthenticationProviderProfileConfiguration (even if badly named for now) interfaces for separating off the required methods. But yeah, it still needs looking at (just glancing at the class diagram is enough to think this is probably crazy).

( https://shibboleth.atlassian.net/secure/attachment/10705/10705_image-20230324-171256.png )

everything is in the net.shibboleth.oidc.profile.config and net.shibboleth.oidc.profile.oauth2.config packages of profile-api and profile-impl.

( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiY2JhMjVhMzU5OTI1NGI4OWEyOTRjY2ExODgxOGExMmUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JCOMOIDC-66#add-comment?atlOrigin=eyJpIjoiY2JhMjVhMzU5OTI1NGI4OWEyOTRjY2ExODgxOGExMmUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100219- sha1:ac3e918 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230324/fea27ebf/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-5bd703ad-9753-4b29-a1ed-d391716906b2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230324/fea27ebf/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4b8f7608-29f6-4bde-aa4d-5ab1cfadecfb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230324/fea27ebf/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-60f29758-5f48-4020-a225-7259318bc4fd
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230324/fea27ebf/attachment-0005.png>