[java-opensaml] branch main updated: OSJ-377 - ExpiringSAMLArtifactMapEntry has a reversed isValid check

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-opensaml.

View the commit online:
http://git.shibboleth.net/view/?p=java-opensaml.git;a=commit;h=e3c32d55dc9d826873861667df344b33fc394356

The following commit(s) were added to refs/heads/main by this push:
     new e3c32d55d OSJ-377 - ExpiringSAMLArtifactMapEntry has a reversed isValid check
e3c32d55d is described below

commit e3c32d55dc9d826873861667df344b33fc394356
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Fri Mar 17 13:50:08 2023 -0400

    OSJ-377 - ExpiringSAMLArtifactMapEntry has a reversed isValid check
    
    https://shibboleth.atlassian.net/browse/OSJ-377
---
 .../saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java
index e98314aca..af6464c0a 100644
--- a/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java
+++ b/opensaml-saml-api/src/main/java/org/opensaml/saml/common/binding/artifact/ExpiringSAMLArtifactMapEntry.java
@@ -75,7 +75,7 @@ public class ExpiringSAMLArtifactMapEntry extends BasicSAMLArtifactMapEntry {
      * @return true iff the entry is valid as of now
      */
     public boolean isValid() {
-        return expiration == null || expiration.isAfter(Instant.now());
+        return isValid(Instant.now());
     }
 
     /**
@@ -85,7 +85,10 @@ public class ExpiringSAMLArtifactMapEntry extends BasicSAMLArtifactMapEntry {
      * @return true iff the entry is valid as of a specified time
      */
     public boolean isValid(@Nonnull final Instant effectiveTime) {
-        return expiration == null || expiration.isBefore(effectiveTime);
+        if (expiration != null) {
+            return expiration.isAfter(effectiveTime);
+        }
+        return true;
     }
     
 }
\ No newline at end of file

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.