[JIRA] (OSJ-377) ExpiringSAMLArtifactMapEntry has a reversed isValid check

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiNTZkZGY4OTJjN2MwNGMxYWE3ZTNlMDU2MWRkYWYxOGIiLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/OSJ-377?atlOrigin=eyJpIjoiNTZkZGY4OTJjN2MwNGMxYWE3ZTNlMDU2MWRkYWYxOGIiLCJwIjoiaiJ9 ) OSJ-377 ( https://shibboleth.atlassian.net/browse/OSJ-377?atlOrigin=eyJpIjoiNTZkZGY4OTJjN2MwNGMxYWE3ZTNlMDU2MWRkYWYxOGIiLCJwIjoiaiJ9 ) ExpiringSAMLArtifactMapEntry has a reversed isValid check ( https://shibboleth.atlassian.net/browse/OSJ-377?atlOrigin=eyJpIjoiNTZkZGY4OTJjN2MwNGMxYWE3ZTNlMDU2MWRkYWYxOGIiLCJwIjoiaiJ9 )

Issue Type: Bug Affects Versions: 4.0.0, 4.0.1, 4.1.0, 4.1.1, 4.2.0 Assignee: Brent Putman ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A97de0981-adc3-4044-95ed-131622fad81e ) Components: SAML 2 Bindings Created: 17/Mar/23 1:48 PM Fix Versions: 5.0.0 Priority: Major Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

One of the isValid methods that evaluates against an artifically supplied timestamp is reversed and is testing if expiration is before the specified time. The default method based on current time is correct.

( https://shibboleth.atlassian.net/browse/OSJ-377#add-comment?atlOrigin=eyJpIjoiNTZkZGY4OTJjN2MwNGMxYWE3ZTNlMDU2MWRkYWYxOGIiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-377#add-comment?atlOrigin=eyJpIjoiNTZkZGY4OTJjN2MwNGMxYWE3ZTNlMDU2MWRkYWYxOGIiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100218- sha1:9826a04 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230317/4e2ac809/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-a193d28d-ef26-48b3-9250-ab0c30dc491c
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230317/4e2ac809/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-major-e8339fe8-199a-4ed7-8267-267829eb067a
Type: image/png
Size: 821 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230317/4e2ac809/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-a6a33047-5349-444d-96d3-ffabafe2cafc
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230317/4e2ac809/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-6b5992cd-ec39-4b17-b6e3-fab96c3010aa
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230317/4e2ac809/attachment-0007.png>