[java-idp-plugin-oidc-rp] branch main updated: Change name of default authorization code encoder

Phil Smart philip.smart at jisc.ac.uk
Wed Mar 15 11:19:27 UTC 2023


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=8f6fed30047821fcacc6712470296c4597cca622

The following commit(s) were added to refs/heads/main by this push:
     new 8f6fed3  Change name of default authorization code encoder
8f6fed3 is described below

commit 8f6fed30047821fcacc6712470296c4597cca622
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Wed Mar 15 11:19:08 2023 +0000

    Change name of default authorization code encoder
---
 ...questEncoder.java => DefaultAuthCodeTokenRequestEncoder.java} | 9 ++++-----
 .../authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml    | 2 +-
 .../rp/encoding/impl/NimbusAuthCodeTokenRequestEncoderTest.java  | 4 ++--
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoder.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/DefaultAuthCodeTokenRequestEncoder.java
similarity index 91%
rename from idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoder.java
rename to idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/DefaultAuthCodeTokenRequestEncoder.java
index 5daa5a4..93c1ca1 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoder.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/DefaultAuthCodeTokenRequestEncoder.java
@@ -33,15 +33,14 @@ import com.nimbusds.oauth2.sdk.TokenRequest;
 import com.nimbusds.oauth2.sdk.http.HTTPRequest;
 
 /** 
- * A token request encoder that builds an OAuth2.0 Access Token Request for an authorization_code grant 
- * using the Nimbus token request builders. The Nimbus {@link HTTPRequest} is converted to the 
- * returned {@link HttpUriRequest}. 
+ * A token request encoder that builds an OAuth2.0 Access Token Request for an authorization_code grant and returns an
+ * {@link HttpUriRequest}. 
  * */
-public class NimbusAuthCodeTokenRequestEncoder extends AbstractRequestEncoderFunction {
+public class DefaultAuthCodeTokenRequestEncoder extends AbstractRequestEncoderFunction {
     
     /** Class logger. */
     @Nonnull
-    private final Logger log = LoggerFactory.getLogger(NimbusAuthCodeTokenRequestEncoder.class);
+    private final Logger log = LoggerFactory.getLogger(DefaultAuthCodeTokenRequestEncoder.class);
     
     @Override
     @Nullable public HttpUriRequest doApply(@Nonnull final ProfileRequestContext profileRequestContext) {
diff --git a/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml b/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml
index 8ea4172..0ea6106 100644
--- a/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml
+++ b/idp-oidc-rp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/OIDCRelyingParty/oidc-relying-party-authn-beans.xml
@@ -392,7 +392,7 @@
         p:objectMapper="#{getObject('shibboleth.authn.oidc.rp.JSONObjectMapper') ?: getObject('shibboleth.authn.oidc.rp.DefaultJSONObjectMapper')}" />
 
     <bean id="shibboleth.authn.oidc.rp.DefaultAuthCodeTokenResponseEncoder" scope="prototype"
-        class="net.shibboleth.idp.plugin.authn.oidc.rp.encoding.impl.NimbusAuthCodeTokenRequestEncoder" />
+        class="net.shibboleth.idp.plugin.authn.oidc.rp.encoding.impl.DefaultAuthCodeTokenRequestEncoder" />
 
 
     <!-- ID TOKEN Decryption (TODO: should this be a message handler chain for consistency) -->
diff --git a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoderTest.java b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoderTest.java
index be33b90..7264872 100644
--- a/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoderTest.java
+++ b/idp-oidc-rp-impl/src/test/java/net/shibboleth/idp/plugin/authn/oidc/rp/encoding/impl/NimbusAuthCodeTokenRequestEncoderTest.java
@@ -48,13 +48,13 @@ import net.shibboleth.oidc.authn.context.OAuth2ClientAuthenticationContext;
 public class NimbusAuthCodeTokenRequestEncoderTest extends AbstractOIDCTest {
     
     /** The encoder to test.*/
-    private NimbusAuthCodeTokenRequestEncoder encoder;
+    private DefaultAuthCodeTokenRequestEncoder encoder;
     
     @Override
     @BeforeMethod
     public void setup() throws Exception {
         super.setup();
-        encoder = new NimbusAuthCodeTokenRequestEncoder();
+        encoder = new DefaultAuthCodeTokenRequestEncoder();
     }
     
     

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list