[JIRA] (JSSH-25) HttpResource needs some rework to properly close response

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiYzQxOGFlMzdmODA4NDljYzlkM2ZhNzQ5YTg0MDcyODciLCJwIjoiaiJ9 ) / Task ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiYzQxOGFlMzdmODA4NDljYzlkM2ZhNzQ5YTg0MDcyODciLCJwIjoiaiJ9 ) JSSH-25 ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiYzQxOGFlMzdmODA4NDljYzlkM2ZhNzQ5YTg0MDcyODciLCJwIjoiaiJ9 ) HttpResource needs some rework to properly close response ( https://shibboleth.atlassian.net/browse/JSSH-25?atlOrigin=eyJpIjoiYzQxOGFlMzdmODA4NDljYzlkM2ZhNzQ5YTg0MDcyODciLCJwIjoiaiJ9 )

Issue Type: Task Assignee: Unassigned Components: Networking + Spring Created: 13/Mar/23 9:10 AM Fix Versions: 9.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

I think one of the two code paths calling executeOpen may not be reliably closing the response in the case of an errror (no finally), and both of them can be reworked to use try-with-resources.

Alternatively we may want to look at using a response handler I guess.

( https://shibboleth.atlassian.net/browse/JSSH-25#add-comment?atlOrigin=eyJpIjoiYzQxOGFlMzdmODA4NDljYzlkM2ZhNzQ5YTg0MDcyODciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-25#add-comment?atlOrigin=eyJpIjoiYzQxOGFlMzdmODA4NDljYzlkM2ZhNzQ5YTg0MDcyODciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:2199b34 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/ae2d0f94/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-fc43be77-dd53-4f18-a1a1-0707e8195cd8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/ae2d0f94/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-982971a8-b62b-4b26-ace7-08ae7f68c47b
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/ae2d0f94/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-1c3462c8-5354-4a50-b482-019a78c7991e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/ae2d0f94/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-5db6b175-9b98-43e5-8992-c0c90df6268c
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230313/ae2d0f94/attachment-0007.png>