[JIRA] (IDP-2069) Null Handling Task

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2069 ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiMDBhOTMyY2U3MDZkNDllM2FiODVhMDBkMGZmNDk2NDciLCJwIjoiaiJ9 )

Re: Null Handling Task ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiMDBhOTMyY2U3MDZkNDllM2FiODVhMDBkMGZmNDk2NDciLCJwIjoiaiJ9 )

I have gone backwards and tightened out all the nullable behaviors I could fix in AttributeSupport, ElementSupport, etc. in java-shib-shared, along with some adjustments in OpenSAML (and far fewer tweaks elsewhere).

One problem area was that the getChildElements shortcuts that returned collections were odd in that they appeared to return mutable collections except in empty cases, and those were immutable. There was a case in a Spring parser that counted on mutability, and that was sort of a risk so I made them return immutable collections and adjusted the call sites. I think that’s the proper approach.

( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiMDBhOTMyY2U3MDZkNDllM2FiODVhMDBkMGZmNDk2NDciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiMDBhOTMyY2U3MDZkNDllM2FiODVhMDBkMGZmNDk2NDciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:45db922 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230307/19e07dbd/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3efe55f3-d111-4439-a432-4ddb9767ea49
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230307/19e07dbd/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-69dddd2b-55ad-4040-b140-930ef55cb2cd
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230307/19e07dbd/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-6fb34db5-a80d-411a-84e6-b81ab2e64736
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230307/19e07dbd/attachment-0005.png>