[java-shib-attribute] branch main updated: Stop mutating immutable collection.

Scott Cantor cantor.2 at osu.edu
Tue Mar 7 21:46:45 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-shib-attribute.

View the commit online:
http://git.shibboleth.net/view/?p=java-shib-attribute.git;a=commit;h=3bf5910cfe586cdedc7bfa80b4a32dc02b94a7e8

The following commit(s) were added to refs/heads/main by this push:
     new 3bf5910cf Stop mutating immutable collection.
3bf5910cf is described below

commit 3bf5910cfe586cdedc7bfa80b4a32dc02b94a7e8
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Mar 7 16:46:42 2023 -0500

    Stop mutating immutable collection.
---
 .../attribute/resolver/spring/dc/impl/ManagedConnectionParser.java   | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ManagedConnectionParser.java b/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ManagedConnectionParser.java
index c229d12a0..462dab5c8 100644
--- a/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ManagedConnectionParser.java
+++ b/shib-attribute-resolver-spring/src/main/java/net/shibboleth/idp/attribute/resolver/spring/dc/impl/ManagedConnectionParser.java
@@ -17,6 +17,7 @@
 
 package net.shibboleth.idp.attribute.resolver.spring.dc.impl;
 
+import java.util.ArrayList;
 import java.util.List;
 
 import javax.annotation.Nonnull;
@@ -203,8 +204,8 @@ public class ManagedConnectionParser {
             LOG.warn("Only one <BeanManagedConnection> should be specified; the first one has been consulted");
         }
 
-        final List<Element> managedElements = ElementSupport.getChildElements(config, 
-                CONTAINER_MANAGED_CONNECTION_RESOLVER);
+        final List<Element> managedElements = new ArrayList<>(ElementSupport.getChildElements(config, 
+                CONTAINER_MANAGED_CONNECTION_RESOLVER));
         managedElements.addAll(ElementSupport.getChildElements(config, SIMPLE_MANAGED_CONNECTION_RESOLVER));
         
         if (managedElements.size() > 0) {

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list