[java-identity-provider] branch main updated: Fix some warnings.

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=744e457cd3bb0d569698835651fa182c8d756f39

The following commit(s) were added to refs/heads/main by this push:
     new 744e457cd Fix some warnings.
744e457cd is described below

commit 744e457cd3bb0d569698835651fa182c8d756f39
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Mar 2 11:30:45 2023 -0500

    Fix some warnings.
---
 .../idp/authn/impl/ExtractUsernamePasswordFromBasicAuth.java           | 3 ++-
 .../idp/authn/impl/ExtractUsernamePasswordFromFormRequest.java         | 3 ++-
 .../shibboleth/idp/authn/impl/ExtractUsernamePasswordFromWSSToken.java | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromBasicAuth.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromBasicAuth.java
index eeb013a57..df9ed522f 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromBasicAuth.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromBasicAuth.java
@@ -65,7 +65,8 @@ public class ExtractUsernamePasswordFromBasicAuth extends AbstractExtractionActi
     protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final AuthenticationContext authenticationContext) {
 
-        final UsernamePasswordContext upCtx = authenticationContext.getOrCreateSubcontext(UsernamePasswordContext.class);
+        final UsernamePasswordContext upCtx =
+                authenticationContext.getOrCreateSubcontext(UsernamePasswordContext.class);
         upCtx.setUsername(null);
         upCtx.setPassword(null);
         
diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromFormRequest.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromFormRequest.java
index 3963decd4..68e9774a5 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromFormRequest.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromFormRequest.java
@@ -104,7 +104,8 @@ public class ExtractUsernamePasswordFromFormRequest extends AbstractExtractionAc
     protected void doExecute(@Nonnull final ProfileRequestContext profileRequestContext,
             @Nonnull final AuthenticationContext authenticationContext) {
 
-        final UsernamePasswordContext upCtx = authenticationContext.getOrCreateSubcontext(UsernamePasswordContext.class);
+        final UsernamePasswordContext upCtx =
+                authenticationContext.getOrCreateSubcontext(UsernamePasswordContext.class);
         upCtx.setUsername(null);
         upCtx.setPassword(null);
         
diff --git a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromWSSToken.java b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromWSSToken.java
index 8b0c8a9eb..cb4309460 100644
--- a/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromWSSToken.java
+++ b/idp-authn-impl/src/main/java/net/shibboleth/idp/authn/impl/ExtractUsernamePasswordFromWSSToken.java
@@ -120,7 +120,7 @@ public class ExtractUsernamePasswordFromWSSToken extends AbstractExtractionActio
         Password password = null;
         while (passwordsItr.hasNext()) {
             password = (Password) passwordsItr.next();
-            if (password.getType() != null && !password.getType().equals(Password.TYPE_PASSWORD_TEXT)) {
+            if (!Password.TYPE_PASSWORD_TEXT.equals(password.getType())) {
                 log.debug("{} Skipping password with unsupported type {}", getLogPrefix(), password.getType());
                 password = null;
             }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.