[JIRA] (IDP-2069) Null Handling Task

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2069 ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiZWI4MmQ3Njc1NDk3NDg3OThhZmM0ZDIyY2E2YmU2NDUiLCJwIjoiaiJ9 )

Re: Null Handling Task ( https://shibboleth.atlassian.net/browse/IDP-2069?atlOrigin=eyJpIjoiZWI4MmQ3Njc1NDk3NDg3OThhZmM0ZDIyY2E2YmU2NDUiLCJwIjoiaiJ9 )

I think that there is a bug in net.shibboleth.idp.saml.saml2.profile.impl.ContinueSAMLAuthentication#doExecute

There is a compound if statement where every leg builds an event. Then there is another compound if statement where every leg also builds and event. And in particular there is an NPE if profileRequestContext.getInboundMessageContext() is null (even though that condition is explicitly handled in the first compound if statement.

I think that there is an else { missing around the second one. I’ll fix up what I can and leave it to Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) to look at after I push the changes (today or tomorrow),

( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiZWI4MmQ3Njc1NDk3NDg3OThhZmM0ZDIyY2E2YmU2NDUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2069#add-comment?atlOrigin=eyJpIjoiZWI4MmQ3Njc1NDk3NDg3OThhZmM0ZDIyY2E2YmU2NDUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100217- sha1:65be9f2 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230301/7a9cfa17/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-10a9c7c7-9101-4121-a666-444a1d5334f0
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230301/7a9cfa17/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4232a241-4d99-4443-8ecf-1c7dc8753e3b
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230301/7a9cfa17/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-773fcf06-f334-411d-bbd9-dc9c0a8e23b2
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230301/7a9cfa17/attachment-0005.png>