[java-idp-plugin-oidc-rp] branch main updated: Fix typos and final cleanup

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-idp-plugin-oidc-rp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-oidc-rp.git;a=commit;h=d205b721aa206c98f8e9ee1d364f31d978f9aca2

The following commit(s) were added to refs/heads/main by this push:
     new d205b72  Fix typos and final cleanup
d205b72 is described below

commit d205b721aa206c98f8e9ee1d364f31d978f9aca2
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Jun 27 11:51:31 2023 +0100

    Fix typos and final cleanup
---
 .../oidc/rp/impl/InitializeOAuth2ClientAuthenticationContext.java    | 2 +-
 .../rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java   | 5 +++--
 .../oidc/rp/messaging/impl/AddPassiveAuthenticationHandler.java      | 2 +-
 .../impl/ClientAuthenticationConfigurationLookupFunction.java        | 4 ++--
 4 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationContext.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationContext.java
index 2fa6e52..8364a9e 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationContext.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationContext.java
@@ -40,7 +40,7 @@ import net.shibboleth.utilities.java.support.logic.Constraint;
  * 
  * @event {@link org.opensaml.profile.action.EventIds#PROCEED_EVENT_ID}
  * @event {@link EventIds#INVALID_PROFILE_CTX}
- * @post create a {@link OAuth2ClientAuthenticationContext}
+ * @post create an {@link OAuth2ClientAuthenticationContext}
  */
 public class InitializeOAuth2ClientAuthenticationContext extends AbstractMessageHandler {
 
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java
index ace2306..0ac3ae1 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/impl/InitializeOAuth2ClientAuthenticationMethodHandler.java
@@ -176,6 +176,7 @@ public class InitializeOAuth2ClientAuthenticationMethodHandler extends AbstractM
     public void setProviderMetadataLookupStrategy(
             @Nonnull final Function<MessageContext, OIDCProviderMetadataContext> strategy) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
+        ComponentSupport.ifDestroyedThrowDestroyedComponentException(this);
         
         providerMetadataLookupStrategy = 
                 Constraint.isNotNull(strategy,"Provider metadata lookup strategy can not be null");
@@ -189,6 +190,7 @@ public class InitializeOAuth2ClientAuthenticationMethodHandler extends AbstractM
     public void setSecurityParametersContextLookupStrategy(
             @Nonnull final Function<MessageContext, SecurityParametersContext> strategy) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
+        ComponentSupport.ifDestroyedThrowDestroyedComponentException(this);
 
         securityParametersContextLookupStrategy =
                 Constraint.isNotNull(strategy, "JWTSecurityParametersContext lookup strategy cannot be null");
@@ -202,6 +204,7 @@ public class InitializeOAuth2ClientAuthenticationMethodHandler extends AbstractM
     public void setRelyingPartyContextLookupStrategy(
             @Nonnull final Function<ProfileRequestContext,RelyingPartyContext> strategy) {
         ComponentSupport.ifInitializedThrowUnmodifiabledComponentException(this);
+        ComponentSupport.ifDestroyedThrowDestroyedComponentException(this);
         
         relyingPartyContextLookupStrategy =
                 Constraint.isNotNull(strategy, "RelyingPartyContext lookup strategy cannot be null");
@@ -369,8 +372,6 @@ public class InitializeOAuth2ClientAuthenticationMethodHandler extends AbstractM
     /**
      * Build the claim values required for a client authentication bearer JWT.
      * 
-     * @param clientId the client identifier
-     * 
      * @return the constructed JWT claims set
      */
     private JWTClaimsSet buildClientAuthenticationJwtClaims() {        
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddPassiveAuthenticationHandler.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddPassiveAuthenticationHandler.java
index 0dc3ccd..6ebb7e7 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddPassiveAuthenticationHandler.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/messaging/impl/AddPassiveAuthenticationHandler.java
@@ -31,7 +31,7 @@ import com.nimbusds.openid.connect.sdk.Prompt;
 import net.shibboleth.idp.authn.context.AuthenticationContext;
 
 /** 
- * An action that sets the 'prompt' parameter to 'none' if passive authentication has been requested by the
+ * A message handler that sets the 'prompt' parameter to 'none' if passive authentication has been requested by the
  * SP.
  */
 public class AddPassiveAuthenticationHandler extends AbstractOIDCAuthenticationRequestActionMessageHandler {
diff --git a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/ClientAuthenticationConfigurationLookupFunction.java b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/ClientAuthenticationConfigurationLookupFunction.java
index cb1fb0b..4c23e9c 100644
--- a/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/ClientAuthenticationConfigurationLookupFunction.java
+++ b/idp-oidc-rp-impl/src/main/java/net/shibboleth/idp/plugin/authn/oidc/rp/security/impl/ClientAuthenticationConfigurationLookupFunction.java
@@ -109,7 +109,7 @@ public class ClientAuthenticationConfigurationLookupFunction
     }
 
     @Override
-    @Nullable
+    @Nonnull @NonnullElements @NotLive @Unmodifiable
     public List<SignatureSigningConfiguration> apply(@Nullable final MessageContext input) {
 
         final List<SignatureSigningConfiguration> configs = new ArrayList<>();
@@ -163,7 +163,7 @@ public class ClientAuthenticationConfigurationLookupFunction
             }  
         }
 
-        return configsFiltered;
+        return Collections.unmodifiableList(configsFiltered);
     }
     
     /**

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.