[JIRA] (IDP-2133) seckeygen.sh not updated on upgrade to v5

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2133 ( https://shibboleth.atlassian.net/browse/IDP-2133?atlOrigin=eyJpIjoiZjUwMzI4ZmY1NGU2NGQ1MjgyMTVlZmU4MWZjMWZhOWEiLCJwIjoiaiJ9 )

Re: seckeygen.sh not updated on upgrade to v5 ( https://shibboleth.atlassian.net/browse/IDP-2133?atlOrigin=eyJpIjoiZjUwMzI4ZmY1NGU2NGQ1MjgyMTVlZmU4MWZjMWZhOWEiLCJwIjoiaiJ9 )

I’ve bottomed this out and it is pretty hateful. Given that I’m reasonably happy that I’ve fixed the underlying cause I am inclined to move on an we can just suck up the fact that adding files to a module will break automatics re-enabling.

The key is this line in the doco for [URLClassloader|https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/net/URLClassLoader.html#URLClassLoader(java.net.URL[])]

> 
> 
> 
> The URLs will be searched in the order specified for classes and resources
> after first searching in the specified parent class loader.
> 
> 

I was naive enough to assume that the URLs would be put ahead of the current classpath, not behind.

So if you are installing on top of a V4 install and you carefully construct a classpath to point to the old webapp\WEB-INF\lib you will eventually stumble upon the Duo plugin. As that it being instalatiated it will do a claz.getResourceAsStream(DEFAULT_RESOURCE) to get hold of the in the relevant module.

But because the existing classpath is found it will grab hold of the module.properties from the source (distribution) tree and not from the one in the V4 install at this stage “Duo” won’t be found (because it no longer exists).

We would have the same problem if the sort order was reversed - we might find the V4 property file for a V5 module.

The Classloader trick works best when you don’t have any of what you are looking for on the existing classpath - so in the plugin intsaller we start with no plugins available and add either the installed plugins' lib dir or the to be installed plugin’s lib dir.

There is still much I do no completely grock, but for I know enough to know that this will be tricky.

I’ll fix this tomorrow.

( https://shibboleth.atlassian.net/browse/IDP-2133#add-comment?atlOrigin=eyJpIjoiZjUwMzI4ZmY1NGU2NGQ1MjgyMTVlZmU4MWZjMWZhOWEiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2133#add-comment?atlOrigin=eyJpIjoiZjUwMzI4ZmY1NGU2NGQ1MjgyMTVlZmU4MWZjMWZhOWEiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:a102ba3 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230626/ec68e2d2/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4f267f6b-01d9-43bf-b82a-8e6575c9d761
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230626/ec68e2d2/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-7f49167a-192d-438e-803c-76c95333a243
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230626/ec68e2d2/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-32adc85e-129f-4f18-832d-6a5c8dd469e9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230626/ec68e2d2/attachment-0005.png>