[JIRA] (IDP-2133) seckeygen.sh not updated on upgrade to v5

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-2133 ( https://shibboleth.atlassian.net/browse/IDP-2133?atlOrigin=eyJpIjoiMjMyOThjNDQxZWFkNDBlYWJiOTdhMDk3NmJkNTk0NGMiLCJwIjoiaiJ9 )

Re: seckeygen.sh not updated on upgrade to v5 ( https://shibboleth.atlassian.net/browse/IDP-2133?atlOrigin=eyJpIjoiMjMyOThjNDQxZWFkNDBlYWJiOTdhMDk3NmJkNTk0NGMiLCJwIjoiaiJ9 )

It wasn’t the intent really to use optionals, no. I had thought that the determination about what was enabled actually happened in the context of the “old” module definition but I can see why that doesn’t really make much sense.

While I think in this case they probably could be safely treated that way, I’d be concerned that might not be true in every case with these new low level modules, so we may need to just special case those 3 in the installer for upgrades.

( https://shibboleth.atlassian.net/browse/IDP-2133#add-comment?atlOrigin=eyJpIjoiMjMyOThjNDQxZWFkNDBlYWJiOTdhMDk3NmJkNTk0NGMiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2133#add-comment?atlOrigin=eyJpIjoiMjMyOThjNDQxZWFkNDBlYWJiOTdhMDk3NmJkNTk0NGMiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:6a5b8c4 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230622/84b8fded/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-51c4093b-8d7a-4495-8e6d-872e06ee5af4
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230622/84b8fded/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-641a6f00-62c1-41c1-a6c4-bbece451d026
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230622/84b8fded/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-fe15f89f-53e7-4570-9128-adaf18c2458c
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230622/84b8fded/attachment-0005.png>