[java-identity-provider] branch main updated: IDP-2030 Remove Deprecations

Rod Widdowson rdw at steadingsoftware.com
Wed Jun 21 10:02:19 UTC 2023


This is an automated email from the git hooks/post-receive script.

rdw pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=56beb3f907d9f41144a9c0953344aa41914caebb

The following commit(s) were added to refs/heads/main by this push:
     new 56beb3f90 IDP-2030 Remove Deprecations
56beb3f90 is described below

commit 56beb3f907d9f41144a9c0953344aa41914caebb
Author: Rod Widdowson <rdw at steadingsoftware.com>
AuthorDate: Tue Jun 20 16:17:22 2023 +0100

    IDP-2030 Remove Deprecations
    
    https://shibboleth.atlassian.net/browse/IDP-2030
    
    Remove RelyingPartyUIContext#setBrowserLanguages()
---
 .../idp/ui/context/RelyingPartyUIContext.java      | 23 ----------------------
 .../idp/ui/context/RelyingPartyUIContextTest.java  |  4 ++--
 2 files changed, 2 insertions(+), 25 deletions(-)

diff --git a/idp-ui/src/main/java/net/shibboleth/idp/ui/context/RelyingPartyUIContext.java b/idp-ui/src/main/java/net/shibboleth/idp/ui/context/RelyingPartyUIContext.java
index ff4b248d0..d7d8a30a1 100644
--- a/idp-ui/src/main/java/net/shibboleth/idp/ui/context/RelyingPartyUIContext.java
+++ b/idp-ui/src/main/java/net/shibboleth/idp/ui/context/RelyingPartyUIContext.java
@@ -236,29 +236,6 @@ public final class RelyingPartyUIContext extends BaseContext {
         return this;
     }
 
-    /**
-     * Set the browser languages.
-     *
-     * @param languages the languages to set
-     * 
-     * @return this context
-     * 
-     * @deprecated use {@link #setBrowserLanguageRanges(List)}
-     */
-    @Deprecated(since="4.0.0", forRemoval=true)
-    @Nonnull public RelyingPartyUIContext setBrowserLanguages(@Nonnull final List<String> languages) {
-        Constraint.isNotNull(languages, "Language List cannot be null");
-        DeprecationSupport.warnOnce(ObjectType.METHOD, "RelyingPartyUIContext.setBrowserLanguages", null,
-                "setBrowserLanguageRanges");
-        browserLanguages = languages.
-                stream().
-                filter(e -> e != null).
-                map(s -> new LanguageRange(s)).
-                collect(CollectionSupport.nonnullCollector(Collectors.toUnmodifiableList())).
-                get();
-        return this;
-    }
-
     /**
      * Set the browser languages.
      * 
diff --git a/idp-ui/src/test/java/net/shibboleth/idp/ui/context/RelyingPartyUIContextTest.java b/idp-ui/src/test/java/net/shibboleth/idp/ui/context/RelyingPartyUIContextTest.java
index c3096e0d1..fc6a0f7d2 100644
--- a/idp-ui/src/test/java/net/shibboleth/idp/ui/context/RelyingPartyUIContextTest.java
+++ b/idp-ui/src/test/java/net/shibboleth/idp/ui/context/RelyingPartyUIContextTest.java
@@ -170,7 +170,7 @@ public class RelyingPartyUIContextTest extends XMLObjectBaseTestCase {
         Assert.assertNull(ctx.getLogo(66, 1, 100, 10000));
         Assert.assertEquals(ctx.getLogo(), "https://shibboleth.net/images/shibboleth.png");
         
-        ctx.setBrowserLanguages(CollectionSupport.singletonList("de"));
+        ctx.setBrowserLanguageRanges(CollectionSupport.singletonList(new LanguageRange("de")));
         Assert.assertEquals(ctx.getLogo(), "https://shibboleth.net/images/shibboleth.pngde");
 
     }
@@ -178,7 +178,7 @@ public class RelyingPartyUIContextTest extends XMLObjectBaseTestCase {
     @Test public void fallbackLanguage() {
         RelyingPartyUIContext ctx = getContext();
         
-        ctx.setBrowserLanguages(CollectionSupport.singletonList("zh"));
+        ctx.setBrowserLanguageRanges(CollectionSupport.singletonList(new LanguageRange("zh")));
         Assert.assertEquals(ctx.getLogo(), "https://shibboleth.net/images/shibboleth.png");
         ctx.setFallbackLanguages(CollectionSupport.singletonList("de"));
         Assert.assertEquals(ctx.getLogo(), "https://shibboleth.net/images/shibboleth.pngde");

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list