[JIRA] (IDP-2114) Add metrics for installed plugins and modules

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2114 ( https://shibboleth.atlassian.net/browse/IDP-2114?atlOrigin=eyJpIjoiZmJlMzlmMDgyMzZmNGExZWIwMzQ0MjJhY2E1MzhjMzciLCJwIjoiaiJ9 )

Re: Add metrics for installed plugins and modules ( https://shibboleth.atlassian.net/browse/IDP-2114?atlOrigin=eyJpIjoiZmJlMzlmMDgyMzZmNGExZWIwMzQ0MjJhY2E1MzhjMzciLCJwIjoiaiJ9 )

Not sure whether net.shibboleth.idp.updateVersion fits in the IdPGuageSet. We need to inject an

p:updateUrls-ref="%{idp.updateCheck.urls:shibboleth.IdPUpdateCheckUrls}"
p:enabled="%{idp.updateCheck.enabled:true}"
p:httpClient-ref="%{idp.updateCheck.httpClient:shibboleth.InternalHttpClient}"
p:securityParams="#{ environment.containsProperty('idp.updateCheck.httpSecurityParameters') ? getObject('idp.updateCheck.httpSecurityParameters') :null}"/>

Which is fine, but it takes away from the simplicity of the guageset..

Oddly enough, in terms of the code it might make more sense to make ReportUpdateStatus (the thing which can decide to report the update status) into a metric of its own. All the plumbing is there and we can just have a idp.updateCheck.metric.enabled as well as a idp.updateCheck.enabled. (in other words not so much filtered and controlled on or off.

Needs more thought. I’m swithering and currently thinking that maybe it's just easier to add those beans to the IdPGuageSet (since the reporting is very different. ReportUpdateStatus is careful about what log levels it outputs at whereas the metric just needs to return the update state (out of date, secAdv, up to date).

( https://shibboleth.atlassian.net/browse/IDP-2114#add-comment?atlOrigin=eyJpIjoiZmJlMzlmMDgyMzZmNGExZWIwMzQ0MjJhY2E1MzhjMzciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2114#add-comment?atlOrigin=eyJpIjoiZmJlMzlmMDgyMzZmNGExZWIwMzQ0MjJhY2E1MzhjMzciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:5147d46 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/f6e2724b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-8e194392-c545-45cf-a4ce-cccdbefb4299
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/f6e2724b/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-b77fbb65-172b-416c-917e-03dd71178416
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/f6e2724b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-4bf8659c-c418-4f12-8b58-8c02aa97e93e
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/f6e2724b/attachment-0005.png>