[JIRA] (IDP-2129) Review Installer for Resource use (spring or shibboleth)

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2129 ( https://shibboleth.atlassian.net/browse/IDP-2129?atlOrigin=eyJpIjoiNjM0NmU5ODFlZDM3NDI1YTg4YzdiYWZiZmZjZGIxYTciLCJwIjoiaiJ9 )

Re: Review Installer for Resource use (spring or shibboleth) ( https://shibboleth.atlassian.net/browse/IDP-2129?atlOrigin=eyJpIjoiNjM0NmU5ODFlZDM3NDI1YTg4YzdiYWZiZmZjZGIxYTciLCJwIjoiaiJ9 )

Well I’m glad I reviewed this.

* Most use of resources is spring resources and these are used entirely programmatically for when data may come from the classpath or a file or the web.
* Where we know we are downloading we use out HTTPResource because that accepts (indirectly) HttpClientSecurityParameters
* *BUT* the metadata generator is exactly where https://shibboleth.atlassian.net/browse/IDP-1806 bites us. We are passing an idp.properties into our of our ApplicationContexts then the telling it to create a bean
		p:encryptionCertResource="%{idp.encryption.cert}"
       p:signingCertResource="%{idp.signing.cert}"
       p:backchannelCertResource="%{idp.backchannel.cert}"

So those three setters needed to be changed to use one of our resources (not a spring one). Because the Application context is set up in the canonical manner (using a class that extends IdPPropertiesApplicationContextInitializer ) everything else ‘just works’ including our string to our resource converter (I know this because I tested it)

I also removed this which AIUI is no longer needed (and the generation still works)

	<bean
		class="org.springframework.context.support.PropertySourcesPlaceholderConfigurer"
		p:placeholderPrefix="%{" p:placeholderSuffix="}" />

   <context:property-placeholder />

( https://shibboleth.atlassian.net/browse/IDP-2129#add-comment?atlOrigin=eyJpIjoiNjM0NmU5ODFlZDM3NDI1YTg4YzdiYWZiZmZjZGIxYTciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2129#add-comment?atlOrigin=eyJpIjoiNjM0NmU5ODFlZDM3NDI1YTg4YzdiYWZiZmZjZGIxYTciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:5147d46 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/444930b8/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-79240552-a1fe-4196-ae67-f1dedde85059
Type: image/png
Size: 457 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/444930b8/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4700e80d-c2d8-43c6-be00-c568658da668
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/444930b8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-a19473b2-9b81-4401-a09c-6121a0bd1156
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230617/444930b8/attachment-0005.png>