[JIRA] (IDP-1806) Trailing Blank in idp.authn.LDAP.trustCertificates yields inconsistent error

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on IDP-1806 ( https://shibboleth.atlassian.net/browse/IDP-1806?atlOrigin=eyJpIjoiNmM4NjBlYmRiOWNjNGZiOWI0YjFhMmU4OGJmOTkzZGQiLCJwIjoiaiJ9 )

Re: Trailing Blank in idp.authn.LDAP.trustCertificates yields inconsistent error ( https://shibboleth.atlassian.net/browse/IDP-1806?atlOrigin=eyJpIjoiNmM4NjBlYmRiOWNjNGZiOWI0YjFhMmU4OGJmOTkzZGQiLCJwIjoiaiJ9 )

Most of the manageable cases have been switched over to our Resource interface for consistency, and/or because things were already being moved around or changed, so it was plausible to do so.

I believe the DataConnector issue was already addressed by removing the support for this.

The installer is now impl so anything we’d need to change we could.

I left the unlock keys use case alone because it would be a breaking issue and it’a deprecated feature anyway.

The low level CLI classes really can’t easily change because they interact with Spring directly. Generally when Spring itself is used, we have to use their Resource because we can’t actually convert ours to theirs. It’s when we go from theirs to ours that it works out to use our interface.

We can discuss whether trimming everything is still a possibility, but the original issue here is now addressed by being consistent in not stripping in some of the affected cases. Notably, some of the code was already trimming the property values on the way in, which is something that we just didn’t do consstently up front, so that led to things being out of sync.

( https://shibboleth.atlassian.net/browse/IDP-1806#add-comment?atlOrigin=eyJpIjoiNmM4NjBlYmRiOWNjNGZiOWI0YjFhMmU4OGJmOTkzZGQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-1806#add-comment?atlOrigin=eyJpIjoiNmM4NjBlYmRiOWNjNGZiOWI0YjFhMmU4OGJmOTkzZGQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100226- sha1:d46780b )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230615/db3eb327/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-d666d22c-9519-4a40-849f-f1a9ba847dc8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230615/db3eb327/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-b93c40b5-9541-453e-87d3-b3eea47cff65
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230615/db3eb327/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-2e4877a5-7f16-4abc-9767-cdca815c5fa1
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230615/db3eb327/attachment-0005.png>