[JIRA] (JSSH-33) Review property placement behavior in context builder

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-33 ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiMDU1ODM5ZGQ3NjU5NGI3NjllY2I2ZTk5NjM5Y2ZmOTAiLCJwIjoiaiJ9 )

Re: Review property placement behavior in context builder ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiMDU1ODM5ZGQ3NjU5NGI3NjllY2I2ZTk5NjM5Y2ZmOTAiLCJwIjoiaiJ9 )

We control this generally. In fact, we already were injecting the PropertyConfigurer via servces-system.xml which I forgot about, so this is kind of “rationalizing” all this to an extent.

The problem we have is that our tests are very sensitive to these settings and we don’t use them consistently, so it leads one to draw the wrong conclusions about the problems.

I still don’t really understand how the replacement “works” when a Spring Resource is used but not ours, but I assume it’s buried in the differences between a Converter and a PropertyEditor, whatever that is.

The secondary issue I hit is that if for some cases the injected processor classes need access to the Spring context or environment, that wasn’t happening. When you declare it as a bean inside, Spring auto-injects those via Aware interfaces. When you create them on your own and pass them into a builder, it doesn’t. So that was easy to fix as long as it’s understood that the context isn’t necessarily started at the time you inject them.

This is not done because what I did was just a quick fix for the tests, but we need to clean this up and control it better.

( https://shibboleth.atlassian.net/browse/JSSH-33#add-comment?atlOrigin=eyJpIjoiMDU1ODM5ZGQ3NjU5NGI3NjllY2I2ZTk5NjM5Y2ZmOTAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-33#add-comment?atlOrigin=eyJpIjoiMDU1ODM5ZGQ3NjU5NGI3NjllY2I2ZTk5NjM5Y2ZmOTAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100226- sha1:c25eebb )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230614/1d8c43c8/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-6d157819-b6e4-415d-a6b0-c818e7ea6ad2
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230614/1d8c43c8/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f20194a3-efff-4b23-b650-d4990b3559c2
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230614/1d8c43c8/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-d2a70993-b6a7-4daa-8731-6a659200eacb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230614/1d8c43c8/attachment-0005.png>