[JIRA] (JSSH-33) Review property placement behavior in context builder

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *commented* on JSSH-33 ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiYmYzMWUzZjRiYmU2NGQyMGJkMGM0NjY0YTQwNGYyZjYiLCJwIjoiaiJ9 )

Re: Review property placement behavior in context builder ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiYmYzMWUzZjRiYmU2NGQyMGJkMGM0NjY0YTQwNGYyZjYiLCJwIjoiaiJ9 )

Subject to further testing, I believe what I got wrong was that the PropertySourcesPlaceholderConfigurer class is really just a BeanFactoryPostProcessor, so we can inject our expected version of it into the context when we build it.

I also think we should be checking any injected bean/factory post processors for the need to inject the ApplicationContext and Environment because Spring won’t do that if they’re added by hand, only when they’re located within the context itself at runtime.

So far this change is fixing the tests I saw break, and hasn’t broken anything else. I believe we will be able to remove a lot of those shibboleth.PropertySourcesPlaceholderConfigurer beans we have all over now, at least from the child contexts we build with this class, but that includes SWF contexts now as well as our services.

( https://shibboleth.atlassian.net/browse/JSSH-33#add-comment?atlOrigin=eyJpIjoiYmYzMWUzZjRiYmU2NGQyMGJkMGM0NjY0YTQwNGYyZjYiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-33#add-comment?atlOrigin=eyJpIjoiYmYzMWUzZjRiYmU2NGQyMGJkMGM0NjY0YTQwNGYyZjYiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100226- sha1:1cc165e )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/0504775a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-3ef5474e-38d4-439a-b895-b8dcfd1ab54a
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/0504775a/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-75b6e135-63a7-42be-8bb5-7658088994e1
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/0504775a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-eaffc6e5-1921-4c05-898e-43f79b5baa38
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/0504775a/attachment-0005.png>