[java-identity-provider] branch main updated: Static setup methods are causing TestNG warning.

Scott Cantor cantor.2 at osu.edu
Tue Jun 13 21:02:31 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=8b94f2cae3a08939e9ba14a86af865c3ff8b8b1c

The following commit(s) were added to refs/heads/main by this push:
     new 8b94f2cae Static setup methods are causing TestNG warning.
8b94f2cae is described below

commit 8b94f2cae3a08939e9ba14a86af865c3ff8b8b1c
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Jun 13 17:02:28 2023 -0400

    Static setup methods are causing TestNG warning.
---
 .../test/java/net/shibboleth/idp/test/flows/AbstractFlowTest.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/idp-conf-impl/src/test/java/net/shibboleth/idp/test/flows/AbstractFlowTest.java b/idp-conf-impl/src/test/java/net/shibboleth/idp/test/flows/AbstractFlowTest.java
index 9c4b92c9d..96510b653 100644
--- a/idp-conf-impl/src/test/java/net/shibboleth/idp/test/flows/AbstractFlowTest.java
+++ b/idp-conf-impl/src/test/java/net/shibboleth/idp/test/flows/AbstractFlowTest.java
@@ -149,7 +149,7 @@ public abstract class AbstractFlowTest extends AbstractTestNGSpringContextTests
     @Nonnull public final static String SAML2_TRANSFORM_C14N_BEAN_NAME = "c14n/SAML2Transform";
 
     /** In-memory directory server. A single instance is used for all child tests. */
-    @NonnullAfterInit private static InMemoryDirectory directoryServer;
+    @NonnullAfterInit private InMemoryDirectory directoryServer;
 
     /** Mock external context. */
     protected MockExternalContext externalContext;
@@ -239,7 +239,7 @@ public abstract class AbstractFlowTest extends AbstractTestNGSpringContextTests
      * Creates an UnboundID in-memory directory server. Leverages LDIF found at {@value #LDIF_FILE}.
      */
     @SuppressWarnings("null")
-    @BeforeSuite public static void setupDirectoryServer() {
+    @BeforeSuite public void setupDirectoryServer() {
         directoryServer =
             new InMemoryDirectory(
                 new String[] {"dc=example,dc=org", "ou=system"},
@@ -255,7 +255,7 @@ public abstract class AbstractFlowTest extends AbstractTestNGSpringContextTests
      * 
      * Always run this method to avoid starting the server multiple times when tests fail.
      */
-    @AfterSuite(alwaysRun = true) public static void teardownDirectoryServer() {
+    @AfterSuite(alwaysRun = true) public void teardownDirectoryServer() {
         if (directoryServer != null) {
             directoryServer.stop(true);
         }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list