[JIRA] (JSSH-33) Spring converters run before property replacement

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

Shibboleth Shared - Java ( https://shibboleth.atlassian.net/browse/JSSH?atlOrigin=eyJpIjoiZDA3ZTI0MGM3YmQ5NDExZWJiYjU1NGJiZDI3MTQ5MDciLCJwIjoiaiJ9 ) / Bug ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiZDA3ZTI0MGM3YmQ5NDExZWJiYjU1NGJiZDI3MTQ5MDciLCJwIjoiaiJ9 ) JSSH-33 ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiZDA3ZTI0MGM3YmQ5NDExZWJiYjU1NGJiZDI3MTQ5MDciLCJwIjoiaiJ9 ) Spring converters run before property replacement ( https://shibboleth.atlassian.net/browse/JSSH-33?atlOrigin=eyJpIjoiZDA3ZTI0MGM3YmQ5NDExZWJiYjU1NGJiZDI3MTQ5MDciLCJwIjoiaiJ9 )

Issue Type: Bug Assignee: Unassigned Components: Spring Created: 13/Jun/23 1:46 PM Fix Versions: 9.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

While investigating other issues with the converters, I discovered that it appears they all run before property replacement happens in Spring, which I don’t exactly understand since that seems like it would never work right.

Pending whether that’s a sign of some other problem, we need to manually perform the replacement inside the converter to get it to work properly. At a minimum this is crucial for the StringToResource converter.

( https://shibboleth.atlassian.net/browse/JSSH-33#add-comment?atlOrigin=eyJpIjoiZDA3ZTI0MGM3YmQ5NDExZWJiYjU1NGJiZDI3MTQ5MDciLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JSSH-33#add-comment?atlOrigin=eyJpIjoiZDA3ZTI0MGM3YmQ5NDExZWJiYjU1NGJiZDI3MTQ5MDciLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100226- sha1:1cc165e )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/3aa92d4a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-bc1840af-ef51-4ee3-afb1-4ae7964b8c4c
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/3aa92d4a/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-9cd43387-2cfc-43d4-a3c5-7bb7aa99bf62
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/3aa92d4a/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f020b229-be51-44a2-850c-b68f5c07b992
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/3aa92d4a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-c02beec9-76c9-43dd-917a-169a1ad79a56
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230613/3aa92d4a/attachment-0007.png>