[JIRA] (IDP-2121) Future Proofing the Module Plugin infrastructure for Future SP use

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2121 ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiMTRjYTQ5NTExODcwNGJkNmE5MTk2NmY5NmJmYjIxNWUiLCJwIjoiaiJ9 )

Re: Future Proofing the Module Plugin infrastructure for Future SP use ( https://shibboleth.atlassian.net/browse/IDP-2121?atlOrigin=eyJpIjoiMTRjYTQ5NTExODcwNGJkNmE5MTk2NmY5NmJmYjIxNWUiLCJwIjoiaiJ9 )

Ick.

The failing code (long path)

public JDBCStoragePlugin() throws IOException, 
 net.shibboleth.idp.plugin.PluginException {

The fix

public JDBCStoragePlugin() throws IOException, 
 net.shibboleth.profile.plugin.PluginException {

And in V5 {{ net.shibboleth.idp.plugin.PluginException}} exists and extends net.shibboleth.profile.plugin.PluginException

The code will work until such time as an exception is raised at which point I haven’t a clue what will happen. This is as true for Plugins as for

Our options

* Suck it up. “The mechanics of a plugins and its modules may work in V5 without recompile but they should be recompiled”.
This is where we are right now. Its ugly but easy to express
* Suck it up even more and remove the classes who presence allows V4 plugins to load: “V4 plugins & Module will not work in V5. Before you upgrade you *MUST* uninstall all plugins.
This is quite an ask.,
* Make the IdP Module and plugin base class constructors capture the appropriate exception and rethrow as the IdP specific one. yuck.
* Stop the base class from throwing a catchable exception anyway. Currently they throw these exceptions purely because that have caught a a RunTimeException (ConstraintException for the module and Number for the Plugin). Also yuck.

I am too close to the problem to have anything like an idea of what the right thing to do is, but I suspect that Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) will say that making this correct is more important that guaranteeing a no recompile upgrade path for the vanishingly low number of plugins that don’t already need a recompile so where we are is correct.

In the immediate II'll fix the JDBC plugin and see whether we can upgrade a V4 install with a plugin to V5.

( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiMTRjYTQ5NTExODcwNGJkNmE5MTk2NmY5NmJmYjIxNWUiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2121#add-comment?atlOrigin=eyJpIjoiMTRjYTQ5NTExODcwNGJkNmE5MTk2NmY5NmJmYjIxNWUiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:956085d )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/f0126f8f/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-4be78cfd-eeae-4565-bcbf-8bfb1929cec8
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/f0126f8f/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-e26c50e3-7758-4079-971a-f34eacbf79bf
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/f0126f8f/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-3eb914cb-522e-4445-9cd4-060842142d16
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230609/f0126f8f/attachment-0005.png>