[JIRA] (JOIDC-162) The default audit extractor for %fauth causes ClassCastException to be thrown
Henri Mikkonen (Jira)
jira at shibboleth.atlassian.net
Tue Jun 6 11:15:51 UTC 2023
Henri Mikkonen ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A1614c4a5-c89e-4edc-9421-990bd6ea85fd ) *commented* on JOIDC-162 ( https://shibboleth.atlassian.net/browse/JOIDC-162?atlOrigin=eyJpIjoiNDY1MDU0N2RlOGY3NDA4YmE4NmI5MDcyYmEwOWUzMDQiLCJwIjoiaiJ9 )
Re: The default audit extractor for %fauth causes ClassCastException to be thrown ( https://shibboleth.atlassian.net/browse/JOIDC-162?atlOrigin=eyJpIjoiNDY1MDU0N2RlOGY3NDA4YmE4NmI5MDcyYmEwOWUzMDQiLCJwIjoiaiJ9 )
For me it feels that the best way to fix this would be to update the *ForceAuthnAuditExtractor* class on commons to tackle both message formats (Nimbus AuthenticationRequest and the OIDCAuthenticationRequest used by RP). The lookup strategy fed to that class constructor is currently
Function<ProfileRequestContext, OIDCAuthenticationRequest>
If we change that into
Function<ProfileRequestContext, Object>
and make the code to tackle both message formats via Object, then the current XML-wirings on RP and OP wouldn’t need any changes. A patch release would only be needed for java-oidc-common.
( https://shibboleth.atlassian.net/browse/JOIDC-162#add-comment?atlOrigin=eyJpIjoiNDY1MDU0N2RlOGY3NDA4YmE4NmI5MDcyYmEwOWUzMDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/JOIDC-162#add-comment?atlOrigin=eyJpIjoiNDY1MDU0N2RlOGY3NDA4YmE4NmI5MDcyYmEwOWUzMDQiLCJwIjoiaiJ9 )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:3b7cdab )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/c24038d0/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-941a251d-af83-4545-be6d-e0258af34d93
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/c24038d0/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-d72152ad-8987-4602-a649-dc5651aff216
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/c24038d0/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-45ad109f-a6ec-4727-9e91-b27c04ec28d5
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230606/c24038d0/attachment-0005.png>
More information about the commits
mailing list