[java-identity-provider] branch main updated: Revert "IDP-2063 - Default cookies and examples to __Host- prefixed"

Scott Cantor cantor.2 at osu.edu
Thu Jun 1 14:35:24 UTC 2023


This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-identity-provider.

View the commit online:
http://git.shibboleth.net/view/?p=java-identity-provider.git;a=commit;h=ab870f9019db404363e5a755528d1e12307b7c92

The following commit(s) were added to refs/heads/main by this push:
     new ab870f901 Revert "IDP-2063 - Default cookies and examples to __Host- prefixed"
ab870f901 is described below

commit ab870f9019db404363e5a755528d1e12307b7c92
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Thu Jun 1 09:48:28 2023 -0400

    Revert "IDP-2063 - Default cookies and examples to __Host- prefixed"
    
    This reverts commit 22ad2649b143e146cfe06c236cb7c311a1e65e45.
---
 .../src/main/resources/net/shibboleth/idp/conf/global-system.xml  | 8 ++++----
 .../main/resources/net/shibboleth/idp/module/conf/idp.properties  | 6 +++---
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/global-system.xml b/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/global-system.xml
index 838148424..f3902dc53 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/global-system.xml
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/conf/global-system.xml
@@ -293,7 +293,7 @@
         p:httpOnly="%{idp.cookie.httpOnly:true}"
         p:cookieDomain="%{idp.cookie.domain:}"
         p:cookiePath="%{idp.cookie.path:/}"
-        p:maxAge="%{idp.cookie.maxAge:P1Y}" />
+        p:maxAge="%{idp.cookie.maxAge:31536000}" />
 
     <bean id="shibboleth.UserPrefsCookieManager" class="net.shibboleth.shared.net.CookieManager"
         p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
@@ -302,7 +302,7 @@
         p:httpOnly="false"
         p:cookieDomain="%{idp.cookie.domain:}"
         p:cookiePath="%{idp.cookie.path:/}"
-        p:maxAge="%{idp.cookie.maxAge:P1Y}" />
+        p:maxAge="%{idp.cookie.maxAge:31536000}" />
 
     <bean id="shibboleth.StorageService" lazy-init="true"
         class="%{idp.storage.StorageService:org.opensaml.storage.impl.MemoryStorageService}"
@@ -312,14 +312,14 @@
         class="org.opensaml.storage.impl.client.ClientStorageService"
         p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
         p:cookieManager-ref="shibboleth.CookieManager"
-        p:storageName="%{idp.storage.clientSessionStorageName:__Host-shib_idp_session_ss}"
+        p:storageName="%{idp.storage.clientSessionStorageName:shib_idp_session_ss}"
         p:dataSealer-ref="shibboleth.DataSealer" />
 
     <bean id="shibboleth.ClientPersistentStorageService" lazy-init="true"
         class="org.opensaml.storage.impl.client.ClientStorageService"
         p:httpServletRequestSupplier-ref="shibboleth.HttpServletRequestSupplier"
         p:cookieManager-ref="shibboleth.PersistentCookieManager"
-        p:storageName="%{idp.storage.clientPersistentStorageName:__Host-shib_idp_persistent_ss}"
+        p:storageName="%{idp.storage.clientPersistentStorageName:shib_idp_persistent_ss}"
         p:dataSealer-ref="shibboleth.DataSealer"
         p:keyStrategy-ref="#{ '%{idp.sealer.keyStrategy:shibboleth.DataSealerKeyStrategy}'.trim() }" />
 
diff --git a/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/idp.properties b/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/idp.properties
index f9c417afb..ec4833001 100644
--- a/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/idp.properties
+++ b/idp-conf-impl/src/main/resources/net/shibboleth/idp/module/conf/idp.properties
@@ -27,7 +27,7 @@ idp.scope = example.org
 #idp.cookie.domain =
 # Note the path is now / to allow defaulting to __Host- prefixed names.
 #idp.cookie.path = /
-#idp.cookie.maxAge = P1Y
+#idp.cookie.maxAge = 31536000
 # These control operation of the SameSite filter, which is off by default.
 #idp.cookie.sameSite = None
 #idp.cookie.sameSiteCondition = shibboleth.Conditions.FALSE
@@ -107,8 +107,8 @@ idp.trust.certificates = shibboleth.ExplicitKeyX509TrustEngine
 # Configuration of client- and server-side storage plugins
 #idp.storage.cleanupInterval = PT10M
 idp.storage.htmlLocalStorage = true
-#idp.storage.clientSessionStorageName = __Host-shib_idp_session_ss
-#idp.storage.clientPersistentStorageName = __Host-shib_idp_persistent_ss
+#idp.storage.clientSessionStorageName = shib_idp_session_ss
+#idp.storage.clientPersistentStorageName = shib_idp_persistent_ss
 
 # Set to true to expose more detailed errors in responses to SPs
 #idp.errors.detailed = false

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list