[JIRA] (IDP-2138) update CLI could be more informative

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2138 ( https://shibboleth.atlassian.net/browse/IDP-2138?atlOrigin=eyJpIjoiZDY5ZWNjZjFhMTdiNDVkYjk5ODI5MjY3NDZlZTdhNjAiLCJwIjoiaiJ9 )

Re: update CLI could be more informative ( https://shibboleth.atlassian.net/browse/IDP-2138?atlOrigin=eyJpIjoiZDY5ZWNjZjFhMTdiNDVkYjk5ODI5MjY3NDZlZTdhNjAiLCJwIjoiaiJ9 )

Turns out that without the --list qualifier update only checks for update and emits nothing else.

Proposal is to align this with ReportUpdateStatus:

if (newIdPVersion == null) {
   log.info("No upgrade available from {}", version);
} else {
   log.warn("Version {} can be upgraded to {}", version, newIdPVersion);
}

final SupportLevel sl = verInfo.getSupportLevel();
   switch (sl) {
       case Current:
           log.debug("Version {} is current");
           break;
       case Secadv:
           log.error("Version {} has known security vulnerabilities", version);
           break;
       default:
           log.warn("Support level for {} is {}", version, sl);
           break;
}

The only question being whether debug is the correct level to report a Current version. I am inclined to bump both to info. The signal to noise ratio at debug for the output command is too high to make debug sensible and in the start up logging an extra line is low cost.

Any thoughts Ian Young ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3Ae127cb03-43ed-473d-b6ba-592949cb4be8 ) ?

( https://shibboleth.atlassian.net/browse/IDP-2138#add-comment?atlOrigin=eyJpIjoiZDY5ZWNjZjFhMTdiNDVkYjk5ODI5MjY3NDZlZTdhNjAiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2138#add-comment?atlOrigin=eyJpIjoiZDY5ZWNjZjFhMTdiNDVkYjk5ODI5MjY3NDZlZTdhNjAiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230703/46b58f31/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-85557d2b-a481-4baa-b7c8-49038f6e5b6d
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230703/46b58f31/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-98d91662-90cc-41b3-ba7c-aa89dd476da9
Type: image/png
Size: 345 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230703/46b58f31/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-06320ca9-d2c3-441f-a0bd-1bf51be135d6
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230703/46b58f31/attachment-0005.png>