[java-oidc-common] branch dev/JCOMOIDC-62 updated: Javadoc fixes

[Phil Smart]

This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch dev/JCOMOIDC-62
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=4aab85920955113e749a8378e1c1bf581280d03d

The following commit(s) were added to refs/heads/dev/JCOMOIDC-62 by this push:
     new 4aab859  Javadoc fixes
4aab859 is described below

commit 4aab85920955113e749a8378e1c1bf581280d03d
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Tue Jan 24 15:50:51 2023 +0000

    Javadoc fixes
---
 .../shibboleth/oidc/security/credential/ClientSecretCredential.java | 4 ++--
 .../net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java | 5 ++---
 .../oidc/profile/config/OIDCAuthorizationConfiguration.java         | 6 ++----
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/security/credential/ClientSecretCredential.java b/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/security/credential/ClientSecretCredential.java
index 4aae81a..b8b0f44 100644
--- a/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/security/credential/ClientSecretCredential.java
+++ b/oidc-common-crypto-api/src/main/java/net/shibboleth/oidc/security/credential/ClientSecretCredential.java
@@ -26,8 +26,8 @@ import com.nimbusds.jose.JOSEException;
 import com.nimbusds.jose.JWEAlgorithm;
 
 /**
- * Credential wrapping a client_secret. Contains method to convert the client_secret into suitable keys used for
- * signing and encryption cryptographic functions.
+ * Credential wrapping a client_secret. Contains methods to convert the client_secret into suitable keys used for
+ * signing and encryption functions.
  * 
  * <p>Note, despite its name, this is not an opensaml {@link Credential} type.</p>
  */
diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java
index f5dcc59..0d0c798 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseSignedJWTTrustEngine.java
@@ -172,9 +172,8 @@ public abstract class BaseSignedJWTTrustEngine<TrustBasisType> implements TrustE
                 if (log.isDebugEnabled()) {
                     final String kid = credential instanceof JWKCredential ?
                             ((JWKCredential) credential).getKid() : null;
-                    log.debug("JWT {} verified using algorithm {}{}", signedJWT.serialize(),
-                            algorithm.getName(), 
-                            kid != null ? " and key " + kid : "");
+                    log.debug("Verified JWT using algorithm {}{}: {} ", algorithm.getName(), 
+                            kid != null ? " and key " + kid : "", signedJWT.serialize());
                 }
                 log.debug("Signature validation using candidate credential was successful");
                 return true;
diff --git a/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCAuthorizationConfiguration.java b/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCAuthorizationConfiguration.java
index 6267628..6b1f6b0 100644
--- a/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCAuthorizationConfiguration.java
+++ b/oidc-common-profile-api/src/main/java/net/shibboleth/oidc/profile/config/OIDCAuthorizationConfiguration.java
@@ -102,10 +102,8 @@ public class OIDCAuthorizationConfiguration extends AbstractOIDCSSOConfiguration
     /** An override to specify a specific redirect_uri to use over the normally computed one.*/
     @Nonnull private Function<ProfileRequestContext, String> redirectUriOverrideLookupStrategy;
 
-    /**
-     * Lookup function to retrieve the client_id from the given profile request context.
-     * Typically obtained from the issuer_id of the downstream relying-party (OP).
-     */
+    /** Lookup function to retrieve the client_id from the given profile request context.*/
+    //TODO this is the same as the issuer in the proxy context?
     @Nonnull private Function<ProfileRequestContext, String> clientIdLookupStrategy;
 
     /**

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.