[JIRA] (IDP-2017) Review all classes for exclusive use of javax.servlet attributes

[Rod Widdowson (Jira)]

Rod Widdowson ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=59fb32bbc24efb3c4ed3c977 ) *commented* on IDP-2017 ( https://shibboleth.atlassian.net/browse/IDP-2017?atlOrigin=eyJpIjoiZjg0MzIxNDE2ZjczNDhhNmI5ZDcxYTRkOWViMDcyMDQiLCJwIjoiaiJ9 )

Re: Review all classes for exclusive use of javax.servlet attributes ( https://shibboleth.atlassian.net/browse/IDP-2017?atlOrigin=eyJpIjoiZjg0MzIxNDE2ZjczNDhhNmI5ZDcxYTRkOWViMDcyMDQiLCJwIjoiaiJ9 )

I am guessing this means things like

ExtractX509CertificateFromRequest.java:            certs = (X509Certificate[]) httpRequest.getAttribute("java.servlet.request.X509Certificate");
X509AuthServlet.java:                certs = (X509Certificate[]) httpRequest.getAttribute("javax.servlet.request.X509Certificate");

(noting the java.servlet in the first

rather than

ExtractX509CertificateFromRequest.java:                (X509Certificate[]) httpRequest.getAttribute("jakarta.servlet.request.X509Certificate");

?

( https://shibboleth.atlassian.net/browse/IDP-2017#add-comment?atlOrigin=eyJpIjoiZjg0MzIxNDE2ZjczNDhhNmI5ZDcxYTRkOWViMDcyMDQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/IDP-2017#add-comment?atlOrigin=eyJpIjoiZjg0MzIxNDE2ZjczNDhhNmI5ZDcxYTRkOWViMDcyMDQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:01e0849 )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230124/33e96ca2/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-164bab7f-05cd-4fcb-8828-a47010e0b2fe
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230124/33e96ca2/attachment-0003.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-0b363819-4a27-4655-bf69-7d3d3a4a2cd9
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230124/33e96ca2/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-9120234e-d8cb-408b-81bf-39d48a006945
Type: image/png
Size: 484 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230124/33e96ca2/attachment-0005.png>