[JIRA] (OSJ-370) XMLObject clone method is needlessly nullable

[Scott Cantor (Jira)]

Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) *created* an issue

OpenSAML - Java ( https://shibboleth.atlassian.net/browse/OSJ?atlOrigin=eyJpIjoiMWJlZjE5MzM1NTRhNDM0NDg2NDZkMzU0YmE0Nzc5ZGQiLCJwIjoiaiJ9 ) / Improvement ( https://shibboleth.atlassian.net/browse/OSJ-370?atlOrigin=eyJpIjoiMWJlZjE5MzM1NTRhNDM0NDg2NDZkMzU0YmE0Nzc5ZGQiLCJwIjoiaiJ9 ) OSJ-370 ( https://shibboleth.atlassian.net/browse/OSJ-370?atlOrigin=eyJpIjoiMWJlZjE5MzM1NTRhNDM0NDg2NDZkMzU0YmE0Nzc5ZGQiLCJwIjoiaiJ9 ) XMLObject clone method is needlessly nullable ( https://shibboleth.atlassian.net/browse/OSJ-370?atlOrigin=eyJpIjoiMWJlZjE5MzM1NTRhNDM0NDg2NDZkMzU0YmE0Nzc5ZGQiLCJwIjoiaiJ9 )

Issue Type: Improvement Assignee: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 ) Components: Core Classes Created: 20/Jan/23 8:54 AM Fix Versions: 5.0.0 Priority: Trivial Reporter: Scott Cantor ( https://shibboleth.atlassian.net/secure/ViewProfile.jspa?accountId=557058%3A5b78efc9-1379-42cc-a3f6-56c6ea3a0007 )

The XMLObjectSupport clone helper method has a pointless carve out for returning null on null input, so this should be converted to non-null both ways. The other methods are also missing return annotations in some cases that are all clear.

( https://shibboleth.atlassian.net/browse/OSJ-370#add-comment?atlOrigin=eyJpIjoiMWJlZjE5MzM1NTRhNDM0NDg2NDZkMzU0YmE0Nzc5ZGQiLCJwIjoiaiJ9 ) Add Comment ( https://shibboleth.atlassian.net/browse/OSJ-370#add-comment?atlOrigin=eyJpIjoiMWJlZjE5MzM1NTRhNDM0NDg2NDZkMzU0YmE0Nzc5ZGQiLCJwIjoiaiJ9 )

Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.core&referrer=utm_source%3DNotificationLink%26utm_medium%3DEmail ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailNotificationLink&mt=8 ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100214- sha1:fa7bc5f )
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://shibboleth.net/pipermail/commits/attachments/20230120/f0d7ec3b/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-comment-icon-0ec78f78-4f3a-4b58-83cc-461183730c7f
Type: image/png
Size: 1084 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230120/f0d7ec3b/attachment-0004.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-avatar-f3f36417-ab66-4ec0-b185-04c0cc537dc0
Type: image/png
Size: 448 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230120/f0d7ec3b/attachment-0005.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-trivial-b1b62371-7421-4beb-b1c5-aeed0de5e78b
Type: image/png
Size: 446 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230120/f0d7ec3b/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: jira-generated-image-static-footer-desktop-logo-8b68b2d5-d326-4250-955e-d880627e77fb
Type: image/png
Size: 10805 bytes
Desc: not available
URL: <http://shibboleth.net/pipermail/commits/attachments/20230120/f0d7ec3b/attachment-0007.png>