[java-idp-plugin-totp] branch main updated: JTOTP-5 - Adjust beans to avoid ServletRequest warnings on IdP 4.3

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository java-idp-plugin-totp.

View the commit online:
http://git.shibboleth.net/view/?p=java-idp-plugin-totp.git;a=commit;h=0c38c01ee436c6d993a6f3a599e3ce361b7d5a3b

The following commit(s) were added to refs/heads/main by this push:
     new 0c38c01  JTOTP-5 - Adjust beans to avoid ServletRequest warnings on IdP 4.3
0c38c01 is described below

commit 0c38c01ee436c6d993a6f3a599e3ce361b7d5a3b
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Tue Jan 17 10:21:36 2023 -0500

    JTOTP-5 - Adjust beans to avoid ServletRequest warnings on IdP 4.3
    
    https://shibboleth.atlassian.net/browse/JTOTP-5
---
 .../META-INF/net/shibboleth/idp/flows/authn/TOTP/TOTP-beans.xml     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/totp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/TOTP/TOTP-beans.xml b/totp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/TOTP/TOTP-beans.xml
index a14093a..4ae51ba 100644
--- a/totp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/TOTP/TOTP-beans.xml
+++ b/totp-impl/src/main/resources/META-INF/net/shibboleth/idp/flows/authn/TOTP/TOTP-beans.xml
@@ -25,19 +25,21 @@
         p:basenames="classpath:/net/shibboleth/idp/plugin/authn/totp/messages"
         p:defaultEncoding="UTF-8" />
 
+    <bean id="InternalHttpServletRequest" class="net.shibboleth.utilities.java.support.net.ThreadLocalHttpServletRequestProxy" />
+
     <!-- Default username comes from previous c14n or session. -->        
     <bean id="DefaultUsernameLookupStrategy"
         class="net.shibboleth.idp.session.context.navigate.CanonicalUsernameLookupStrategy" />
 
     <bean id="ExtractTOTPFromHeader"
         class="net.shibboleth.idp.plugin.authn.totp.impl.ExtractTOTPFromHeader" scope="prototype"
-        p:httpServletRequest-ref="shibboleth.HttpServletRequest"
+        p:httpServletRequest-ref="InternalHttpServletRequest"
         p:usernameLookupStrategy="#{getObject('shibboleth.authn.TOTP.UsernameLookupStrategy') ?: getObject('DefaultUsernameLookupStrategy')}"
         p:headerName="#{'%{idp.authn.TOTP.headerName:X-Shibboleth-TOTP}'.trim()}" />
 
     <bean id="ExtractTOTPFromFormRequest"
         class="net.shibboleth.idp.plugin.authn.totp.impl.ExtractTOTPFromFormRequest" scope="prototype"
-        p:httpServletRequest-ref="shibboleth.HttpServletRequest"
+        p:httpServletRequest-ref="InternalHttpServletRequest"
         p:usernameLookupStrategy="#{getObject('shibboleth.authn.TOTP.UsernameLookupStrategy') ?: getObject('DefaultUsernameLookupStrategy')}"
         p:fieldName="#{'%{idp.authn.TOTP.fieldName:tokencode}'.trim()}" />
             

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.