[cpp-sp] branch main updated: SSPCPP-963 - Warn when redirectLimit is unset

[Scott Cantor]

This is an automated email from the git hooks/post-receive script.

scantor pushed a commit to branch main
in repository cpp-sp.

View the commit online:
http://git.shibboleth.net/view/?p=cpp-sp.git;a=commit;h=d80c8b3fe6698214185e96f2302c729487ec1ac2

The following commit(s) were added to refs/heads/main by this push:
     new d80c8b3f SSPCPP-963 - Warn when redirectLimit is unset
d80c8b3f is described below

commit d80c8b3fe6698214185e96f2302c729487ec1ac2
Author: Scott Cantor <cantor.2 at osu.edu>
AuthorDate: Mon Jan 9 17:06:20 2023 -0500

    SSPCPP-963 - Warn when redirectLimit is unset
    
    https://shibboleth.atlassian.net/browse/SSPCPP-963
---
 shibsp/impl/XMLApplication.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/shibsp/impl/XMLApplication.cpp b/shibsp/impl/XMLApplication.cpp
index 4720320b..6e3f3dc4 100644
--- a/shibsp/impl/XMLApplication.cpp
+++ b/shibsp/impl/XMLApplication.cpp
@@ -175,8 +175,12 @@ XMLApplication::XMLApplication(
                 }
             }
         }
+        else if (base) {
+            m_redirectLimit = REDIRECT_LIMIT_INHERIT;
+        }
         else {
-            m_redirectLimit = base ? REDIRECT_LIMIT_INHERIT : REDIRECT_LIMIT_NONE;
+            m_redirectLimit = REDIRECT_LIMIT_NONE;
+            log.warn("redirectLimit not set, system will operate as an open redirector if not corrected");
         }
 
         // Audit some additional settings for logging purposes.

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.