[java-oidc-common] branch main updated: Remove unnecessary TODO

Phil Smart philip.smart at jisc.ac.uk
Thu Jan 5 13:37:43 UTC 2023


This is an automated email from the git hooks/post-receive script.

philsmart pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=bfaab12889663f195020412eec43b8e88d69c0c3

The following commit(s) were added to refs/heads/main by this push:
     new bfaab12  Remove unnecessary TODO
bfaab12 is described below

commit bfaab12889663f195020412eec43b8e88d69c0c3
Author: Phil Smart <philip.smart at jisc.ac.uk>
AuthorDate: Thu Jan 5 13:37:40 2023 +0000

    Remove unnecessary TODO
---
 .../oidc/security/impl/BaseJWTSignatureSecurityHandler.java   | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseJWTSignatureSecurityHandler.java b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseJWTSignatureSecurityHandler.java
index 3e71d87..27e19a3 100644
--- a/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseJWTSignatureSecurityHandler.java
+++ b/oidc-common-crypto-impl/src/main/java/net/shibboleth/oidc/security/impl/BaseJWTSignatureSecurityHandler.java
@@ -186,16 +186,7 @@ public abstract class BaseJWTSignatureSecurityHandler extends BaseTrustEngineSec
             }
         }
        
-        criteriaSet.add( new UsageCriterion(UsageType.SIGNING) );
-        
-        //TODO should we remove this? 
-        
-//        final SignedJWTSecurityParametersContext secParamsContext =
-//                messageContext.getSubcontext(SignedJWTSecurityParametersContext.class);
-//        if (secParamsContext != null && secParamsContext.getSignatureValidationParameters() != null) {
-//            criteriaSet.add(
-//                    new SignatureValidationParametersCriterion(secParamsContext.getSignatureValidationParameters()));
-//        }
+        criteriaSet.add( new UsageCriterion(UsageType.SIGNING));
         
         return criteriaSet;
     }

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.


More information about the commits mailing list