[java-oidc-common] branch main updated: Verify client credential to exist before adding it to the criteria set.

[Henri Mikkonen]

This is an automated email from the git hooks/post-receive script.

hjmikkon pushed a commit to branch main
in repository java-oidc-common.

View the commit online:
http://git.shibboleth.net/view/?p=java-oidc-common.git;a=commit;h=674f6410ec0a6d1afffb448a906a18d65572ece3

The following commit(s) were added to refs/heads/main by this push:
     new 674f641  Verify client credential to exist before adding it to the criteria set.
674f641 is described below

commit 674f6410ec0a6d1afffb448a906a18d65572ece3
Author: Henri Mikkonen <henri.mikkonen at iki.fi>
AuthorDate: Thu Jan 5 15:15:22 2023 +0200

    Verify client credential to exist before adding it to the criteria set.
---
 .../impl/PopulateJWTSignatureSigningParametersHandler.java    | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/impl/PopulateJWTSignatureSigningParametersHandler.java b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/impl/PopulateJWTSignatureSigningParametersHandler.java
index 0a3d59a..c707c06 100644
--- a/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/impl/PopulateJWTSignatureSigningParametersHandler.java
+++ b/oidc-common-profile-impl/src/main/java/net/shibboleth/oidc/profile/impl/PopulateJWTSignatureSigningParametersHandler.java
@@ -32,6 +32,7 @@ import org.opensaml.profile.context.ProfileRequestContext;
 import org.opensaml.saml.common.messaging.context.SAMLMetadataContext;
 import org.opensaml.saml.common.messaging.context.SAMLPeerEntityContext;
 import org.opensaml.saml.criterion.RoleDescriptorCriterion;
+import org.opensaml.security.credential.Credential;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -320,9 +321,13 @@ public class PopulateJWTSignatureSigningParametersHandler extends AbstractMessag
                         (OIDCAuthorizationConfiguration) rpCtx.getProfileConfig();
                 
                 if (profileConfiguration != null) {
-                    criteria.add(new StaticCredentialCriterion(
-                            profileConfiguration.getClientCredential(
-                                    (ProfileRequestContext)messageContext.getParent())));
+                    final Credential credential = profileConfiguration.getClientCredential(
+                            (ProfileRequestContext)messageContext.getParent());
+                    if (credential != null) {
+                        criteria.add(new StaticCredentialCriterion(credential));
+                    } else {
+                        log.trace("{} No credential found from the profile configuration", getLogPrefix());
+                    }
                 } else {
                     log.trace("{} Profile configuration not available, "
                             + "shared secret signing credential not present", getLogPrefix());

-- 
To stop receiving notification emails like this one, please contact
the administrator of this repository.